Page MenuHomePhabricator

[llvm] [dwarf] Fix DWARFListTableHeader::getOffsetEntry off-by-one
ClosedPublic

Authored by jankratochvil on Mar 13 2021, 1:56 PM.

Details

Summary

D98289 was erroneously reporting invalid range list offset 0x20110 instead of invalid range list table index 0.

Diff Detail

Event Timeline

jankratochvil requested review of this revision.Mar 13 2021, 1:56 PM
jankratochvil created this revision.
labath accepted this revision.Mar 14 2021, 1:08 PM
labath added a subscriber: labath.
labath added inline comments.
llvm/unittests/DebugInfo/DWARF/DWARFListTableTest.cpp
95–96

I think EXPECT_EQ(Offset0, uint64_t(4)); (note missing *) should be enough.

This revision is now accepted and ready to land.Mar 14 2021, 1:08 PM
This revision was landed with ongoing or failed builds.Mar 14 2021, 1:43 PM
This revision was automatically updated to reflect the committed changes.
jankratochvil marked an inline comment as done.Mar 14 2021, 1:44 PM
jankratochvil added inline comments.
llvm/unittests/DebugInfo/DWARF/DWARFListTableTest.cpp
95–96

Nice, I did not know (even std::optional).