[asan][nfc] Fixed test failing on windows due to different printf behaviour.

[oontvoo]

Summary

%p reported prints upper case hex chars on Windows.
The fix is to switch to using %#lx

[thakis]

compiler-rt/test/asan/TestCases/wild_pointer.cpp

17

As far as I know, Windows doesn't print the 0x, which makes the [[ADDR]] capture fail I think. And then the CHECK on the next line would fail too since [[ADDR]] doesn't include the 0x.

So this comment should say "Windows omits the 0x prefix" instead, since that's the problem.

unsigned long is 32-bit on 64-bit Windows (https://en.wikipedia.org/wiki/64-bit_computing#64-bit_data_models) so if you want to keep the current approach you want to use uintptr_t and PRIxPTR from stdint.h and inttypes.h respectively:

#include <inttypes.h>
#include <stdint.h>
#include <stdio.h>
int main() {
	printf("%#" PRIxPTR "\n", (uintptr_t)1231);
}

(Unrelated: Please upload diffs with -U9999)

[oontvoo]

Use PRIxPTR

[oontvoo]

compiler-rt/test/asan/TestCases/wild_pointer.cpp

17

(Unrelated: Please upload diffs with -U9999)

This is the full file (it's not being truncated ...)

[oontvoo]

updated comment

[thakis]

Thanks!

[oontvoo]

rebase

[oontvoo]

Thanks

compiler-rt/test/asan/TestCases/wild_pointer.cpp

 // RUN: %clangxx_asan %s -o %t
 // RUN: not %run %t 2>&1 | FileCheck %s
 // REQUIRES: asan-64-bits
 
+#include <inttypes.h>
 #include <stdarg.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <string.h>
 
 int main() {
   char *p = new char;
   char *dest = new char;
   const size_t offset = 0x4567890123456789;
+
+  // The output here needs to match the output from the sanitizer runtime,
+  // which includes 0x and prints hex in lower case.
+  //
+  // On Windows, %p omits %0x and prints hex characters in upper case,
+  // so we use PRIxPTR instead of %p.
+  fprintf(stderr, "Expected bad addr: %#" PRIxPTR "\n",
+          reinterpret_cast<uintptr_t>(p + offset));
   // Flush it so the output came out before the asan report.
-  fprintf(stderr, "Expected bad addr: %p\n", p + offset);
   fflush(stderr);
+
   memmove(dest, p, offset);
   return 0;
 }
 
 // CHECK: Expected bad addr: [[ADDR:0x[0-9,a-f]+]]
 // CHECK: AddressSanitizer: unknown-crash on address [[ADDR]]
 // CHECK: Address [[ADDR]] is a wild pointer inside of access range of size 0x4567890123456789