[RGT] Fix ASTMatchersTest so all assertions are executed

[probinson]

Summary

Some 'if' conditions turn out always to be true (or always false), so change test
expectations to match.

Found by the Rotten Green Tests project.

[probinson]

+gribozavr who has been in this file most recently

[probinson]

Problem has gone away, test assertions are now executed.

clang/unittests/ASTMatchers/ASTMatchersTest.h

public:
   // Checks that there was exactly one match with the name \c ExpectedName.
   // Note that \c T must be a NamedDecl for this to work.
   VerifyIdIsBoundTo(llvm::StringRef Id, llvm::StringRef ExpectedName,
                     int ExpectedCount = 1)
       : Id(std::string(Id)), ExpectedCount(ExpectedCount), Count(0),
         ExpectedName(std::string(ExpectedName)) {}
 
   void onEndOfTranslationUnit() override {
-    if (ExpectedCount != -1) {
-      EXPECT_EQ(ExpectedCount, Count);
-    }
-    if (!ExpectedName.empty()) {
-      EXPECT_EQ(ExpectedName, Name);
-    }
+    EXPECT_EQ(ExpectedCount, -1);
+    EXPECT_TRUE(ExpectedName.empty());
     Count = 0;
     Name.clear();
   }
 
   ~VerifyIdIsBoundTo() override {
     EXPECT_EQ(0, Count);
     EXPECT_EQ("", Name);
   }
 
   bool run(const BoundNodes *Nodes) override {
     const BoundNodes::IDToNodeMap &M = Nodes->getMap();
-    if (Nodes->getNodeAs<T>(Id)) {
-      ++Count;
-      if (const NamedDecl *Named = Nodes->getNodeAs<NamedDecl>(Id)) {
-        Name = Named->getNameAsString();
-      } else if (const NestedNameSpecifier *NNS =
-                     Nodes->getNodeAs<NestedNameSpecifier>(Id)) {
-        llvm::raw_string_ostream OS(Name);
-        NNS->print(OS, PrintingPolicy(LangOptions()));
-      }
-      BoundNodes::IDToNodeMap::const_iterator I = M.find(Id);
-      EXPECT_NE(M.end(), I);
-      if (I != M.end()) {
-        EXPECT_EQ(Nodes->getNodeAs<T>(Id), I->second.get<T>());
-      }
-      return true;
-    }
-    EXPECT_TRUE(M.count(Id) == 0 ||
-                M.find(Id)->second.template get<T>() == nullptr);
-    return false;
-  }
+    EXPECT_NE(Nodes->getNodeAs<T>(Id), nullptr);
 
   bool run(const BoundNodes *Nodes, ASTContext *Context) override {
     return run(Nodes);
   }
 
 private:
   const std::string Id;
   const int ExpectedCount;