This is an archive of the discontinued LLVM Phabricator instance.

Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.
ClosedPublic

Authored by akhuang on Mar 11 2021, 5:21 PM.

Details

Summary

The MSVC runtime library doesn't have a definition for wmemchr,
so provide an inline implementation.

Diff Detail

Event Timeline

akhuang requested review of this revision.Mar 11 2021, 5:21 PM
akhuang created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2021, 5:21 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rnk accepted this revision.Mar 15 2021, 1:18 PM

lgtm w nit

clang/test/CodeGen/wmemchr.c
8

I'd start these off with CHECK-LABEL: define i16* @wmemchr_test as a little bit of future proofing.

This revision is now accepted and ready to land.Mar 15 2021, 1:18 PM
akhuang updated this revision to Diff 330826.Mar 15 2021, 3:30 PM
akhuang marked an inline comment as done.

add CHECK line to test

This revision was landed with ongoing or failed builds.Mar 15 2021, 3:32 PM
This revision was automatically updated to reflect the committed changes.