This is an archive of the discontinued LLVM Phabricator instance.

[M68k] Fix extract-section.py under Python 3
ClosedPublic

Authored by ricky26 on Mar 11 2021, 8:00 AM.

Details

Summary

read_raw_stdin() was opening a file in binary mode, but Popen
was being told to use text mode (universal_newlines). This is
benign on Python 2 but an error on Python 3.

Diff Detail

Event Timeline

ricky26 requested review of this revision.Mar 11 2021, 8:00 AM
ricky26 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2021, 8:00 AM
myhsu accepted this revision.Mar 11 2021, 9:21 AM

yes you're right about this, thanks :-)
LGTM

This revision is now accepted and ready to land.Mar 11 2021, 9:21 AM
myhsu added a comment.Mar 11 2021, 9:33 AM

If you don't have commit access I can commit on your behave

I do not, please commit this @myhsu! :)

This revision was automatically updated to reflect the committed changes.