This is an archive of the discontinued LLVM Phabricator instance.

Differential D98375

[clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag
ClosedPublic

Authored by leonardchan on Mar 10 2021, 3:53 PM.

Details

Reviewers
phosek
mcgrathr
Commits
rG70af0bf6fe46: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag
Summary

Initially, this flag was meant to only be used through cc1 and not directly through the clang driver. However, we accidentally ended up using this flag as a driver flag already for selecting multilibs within the fuchsia toolchain. We're currently in an awkward state where it's only accepted as a driver flag when targeting Fuchsia, and all other instances it can only be added via -Xclang. Since we're ready to use this in Fuchsia, we can just expose this to the driver for simplicity.

Diff Detail

Event Timeline

leonardchan requested review of this revision.Mar 10 2021, 3:53 PM
leonardchan created this revision.
phosek accepted this revision.Mar 10 2021, 3:55 PM

LGTM

This revision is now accepted and ready to land.Mar 10 2021, 3:55 PM
This revision was landed with ongoing or failed builds.Mar 10 2021, 4:29 PM
Closed by commit rG70af0bf6fe46: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag (authored by leonardchan). · Explain Why
This revision was automatically updated to reflect the committed changes.
leonardchan added a commit: rG70af0bf6fe46: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag.
Harbormaster completed remote builds in B93184: Diff 329794.Mar 11 2021, 2:40 AM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
3 lines
test/
Driver/
7 lines

Diff 329800

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,863 Lines • ▼ Show 20 Lines if (!Args.hasFlag(options::OPT_foptimize_sibling_calls,
CmdArgs.push_back("-mdisable-tail-calls"); CmdArgs.push_back("-mdisable-tail-calls");
if (Args.hasFlag(options::OPT_fno_escaping_block_tail_calls, if (Args.hasFlag(options::OPT_fno_escaping_block_tail_calls,
options::OPT_fescaping_block_tail_calls, false)) options::OPT_fescaping_block_tail_calls, false))
CmdArgs.push_back("-fno-escaping-block-tail-calls"); CmdArgs.push_back("-fno-escaping-block-tail-calls");
Args.AddLastArg(CmdArgs, options::OPT_ffine_grained_bitfield_accesses, Args.AddLastArg(CmdArgs, options::OPT_ffine_grained_bitfield_accesses,
options::OPT_fno_fine_grained_bitfield_accesses); options::OPT_fno_fine_grained_bitfield_accesses);
Args.AddLastArg(CmdArgs, options::OPT_fexperimental_relative_cxx_abi_vtables,
options::OPT_fno_experimental_relative_cxx_abi_vtables);
// Handle segmented stacks. // Handle segmented stacks.
if (Args.hasArg(options::OPT_fsplit_stack)) if (Args.hasArg(options::OPT_fsplit_stack))
CmdArgs.push_back("-split-stacks"); CmdArgs.push_back("-split-stacks");
RenderFloatingPointOptions(TC, D, OFastEnabled, Args, CmdArgs, JA); RenderFloatingPointOptions(TC, D, OFastEnabled, Args, CmdArgs, JA);
if (Arg *A = Args.getLastArg(options::OPT_mdouble_EQ)) { if (Arg *A = Args.getLastArg(options::OPT_mdouble_EQ)) {
if (TC.getArch() == llvm::Triple::avr) if (TC.getArch() == llvm::Triple::avr)
▲ Show 20 Lines • Show All 2,711 Lines • Show Last 20 Lines

clang/test/Driver/relative-vtables-flag.cpp

  • This file was added.
// RUN: %clangxx --target=aarch64-unknown-fuchsia -fexperimental-relative-c++-abi-vtables -c %s -### 2>&1 | FileCheck %s --check-prefix=RV
// RUN: %clangxx --target=aarch64-unknown-fuchsia -fno-experimental-relative-c++-abi-vtables -c %s -### 2>&1 | FileCheck %s --check-prefix=NO-RV
// RUN: %clangxx --target=aarch64-unknown-fuchsia -c %s -### 2>&1 | FileCheck %s --check-prefix=NO-RV
// RUN: %clangxx --target=aarch64-unknown-linux-gnu -c %s -### 2>&1 | FileCheck %s --check-prefix=NO-RV
// RV: "-fexperimental-relative-c++-abi-vtables"
// NO-RV-NOT: "-fexperimental-relative-c++-abi-vtables"