For N32/N64, private labels begin with '.L' but for O32 they begin with '$'.
MCAsmInfo now has an initializer function which can be used to provide information from the TargetMachine to control the assembly syntax.
Paths
| Differential D9821
[mips] The naming convention for private labels is ABI dependant. ClosedPublic Authored by dsanders on May 18 2015, 2:39 AM.
Details Summary For N32/N64, private labels begin with '.L' but for O32 they begin with '$'. MCAsmInfo now has an initializer function which can be used to provide information from the TargetMachine to control the assembly syntax.
Diff Detail Event TimelineComment Actions Won't we have to update the existing tests that depend on this behaviour? Failing Tests (12): LLVM :: CodeGen/Mips/analyzebranch.ll LLVM :: CodeGen/Mips/atomic.ll LLVM :: CodeGen/Mips/blez_bgez.ll LLVM :: CodeGen/Mips/blockaddr.ll LLVM :: CodeGen/Mips/fpbr.ll LLVM :: CodeGen/Mips/llvm-ir/ashr.ll LLVM :: CodeGen/Mips/llvm-ir/indirectbr.ll LLVM :: CodeGen/Mips/llvm-ir/lshr.ll LLVM :: CodeGen/Mips/llvm-ir/select.ll LLVM :: CodeGen/Mips/llvm-ir/shl.ll LLVM :: CodeGen/Mips/longbranch.ll LLVM :: CodeGen/Mips/octeon.ll Other than that it looks good to me. Please, update the existing revision if you'd like me to review the tests' changes too. dsanders edited edge metadata. Comment ActionsNow uses the ABI instead of misusing target triples. This required the addition Also updated tests. This revision is now accepted and ready to land.May 20 2015, 3:16 AM
Revision Contents
Diff 26045 include/llvm/MC/MCAsmInfo.h
lib/CodeGen/LLVMTargetMachine.cpp
lib/Target/Mips/MCTargetDesc/MipsABIInfo.h
lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp
lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.h
lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp
lib/Target/Mips/MipsTargetMachine.cpp
test/CodeGen/Mips/analyzebranch.ll
test/CodeGen/Mips/atomic.ll
test/CodeGen/Mips/blez_bgez.ll
test/CodeGen/Mips/blockaddr.ll
test/CodeGen/Mips/fpbr.ll
test/CodeGen/Mips/llvm-ir/ashr.ll
test/CodeGen/Mips/llvm-ir/indirectbr.ll
test/CodeGen/Mips/llvm-ir/lshr.ll
test/CodeGen/Mips/llvm-ir/select.ll
test/CodeGen/Mips/llvm-ir/shl.ll
test/CodeGen/Mips/longbranch.ll
test/CodeGen/Mips/octeon.ll
test/CodeGen/Mips/private_label.ll
|