This is an archive of the discontinued LLVM Phabricator instance.

Differential D98107

[libcxx] [test] Fix path.itr/iterator.pass.cpp for windows
ClosedPublic

Authored by mstorsjo on Mar 5 2021, 11:54 PM.

Details

Reviewers
curdeius
• Quuxplusone
Group Reviewers
Restricted Project
Commits
rG15fdd536f921: [libcxx] [test] Fix path.itr/iterator.pass.cpp for windows

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 5 2021, 11:54 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 11:54 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B92467: Diff 328744.Mar 6 2021, 4:01 AM
curdeius accepted this revision as: curdeius.Mar 6 2021, 4:36 AM
curdeius added a subscriber: curdeius.

LGTM.

• Quuxplusone accepted this revision.Mar 6 2021, 7:51 AM
• Quuxplusone added a subscriber: • Quuxplusone.

LGTM!

This revision is now accepted and ready to land.Mar 6 2021, 7:51 AM
Closed by commit rG15fdd536f921: [libcxx] [test] Fix path.itr/iterator.pass.cpp for windows (authored by mstorsjo). · Explain WhyMar 6 2021, 9:27 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG15fdd536f921: [libcxx] [test] Fix path.itr/iterator.pass.cpp for windows.

Revision Contents

PathSize
libcxx/
test/
std/
input.output/
filesystems/
class.path/
path.itr/
4 lines

Diff 328774

libcxx/test/std/input.output/filesystems/class.path/path.itr/iterator.pass.cpp

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines using It = path::iterator;
assert(default_constructed == p.begin()); assert(default_constructed == p.begin());
assert(default_constructed != p.end()); assert(default_constructed != p.end());
default_constructed = p.end(); default_constructed = p.end();
assert(default_constructed == p.end()); assert(default_constructed == p.end());
assert(default_constructed != p.begin()); assert(default_constructed != p.begin());
} }
{ {
path p("//root_name//first_dir////second_dir"); path p("//root_name//first_dir////second_dir");
#ifdef _WIN32
const path expect[] = {"//root_name", "/", "first_dir", "second_dir"};
#else
const path expect[] = {"/", "root_name", "first_dir", "second_dir"}; const path expect[] = {"/", "root_name", "first_dir", "second_dir"};
#endif
assert(checkCollectionsEqual(p.begin(), p.end(), std::begin(expect), std::end(expect))); assert(checkCollectionsEqual(p.begin(), p.end(), std::begin(expect), std::end(expect)));
assert(checkCollectionsEqualBackwards(p.begin(), p.end(), std::begin(expect), std::end(expect))); assert(checkCollectionsEqualBackwards(p.begin(), p.end(), std::begin(expect), std::end(expect)));
} }
{ {
path p("////foo/bar/baz///"); path p("////foo/bar/baz///");
const path expect[] = {"/", "foo", "bar", "baz", ""}; const path expect[] = {"/", "foo", "bar", "baz", ""};
assert(checkCollectionsEqual(p.begin(), p.end(), std::begin(expect), std::end(expect))); assert(checkCollectionsEqual(p.begin(), p.end(), std::begin(expect), std::end(expect)));
Show All 13 Lines