This is an archive of the discontinued LLVM Phabricator instance.

[sanitizers] fix print-module-map test on linux
ClosedPublic

Authored by aralisza on Mar 5 2021, 4:27 PM.

Download Raw Diff

Details

Reviewers

vitalybuka
delcypher

Commits

rGc0503df15d58: [sanitizers] fix print-module-map test on linux

Summary

Looks like the default options for halt_on_error are different between linux and mac. set it to 0 in the test so the behavior is the same on both platforms.

rdar://75110847

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

aralisza requested review of this revision.Mar 5 2021, 4:27 PM

aralisza created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 4:27 PM

Herald added a subscriber: Restricted Project. · View Herald Transcript

build failure: https://lab.llvm.org/buildbot/#/builders/105/builds/6556

aralisza edited the summary of this revision. (Show Details)Mar 5 2021, 4:38 PM

LGTM.

This revision is now accepted and ready to land.Mar 5 2021, 4:38 PM

looks like the Debian pre-merge checks passed. not going to wait for windows since this test isn't run on windows

This revision was landed with ongoing or failed builds.Mar 5 2021, 4:41 PM

Closed by commit rGc0503df15d58: [sanitizers] fix print-module-map test on linux (authored by aralisza). · Explain Why

This revision was automatically updated to reflect the committed changes.

aralisza added a commit: rGc0503df15d58: [sanitizers] fix print-module-map test on linux.

In D98089#2608226, @aralisza wrote:

looks like the Debian pre-merge checks passed. not going to wait for windows since this test isn't run on windows

I guess this is not a solution.
It worked on Debian before, it's something about PPC

"ABORTING" in case of ubsan is result of UndefinedBehaviorSanitizer:DEADLYSIGNAL, not ubsan report itself.
Somehow it didn't trigger signal on PPC, so hald on error will not help

However "abort_on_error=1" may help as it makes print ABORT even before signal.
abort_on_error=1 is default on Darwin/Android and 0 on the rest

vitalybuka mentioned this in rG1c5f08312874: [NFC] Fix module map test.Mar 5 2021, 5:24 PM

What do you think if I just disable the test on power pc? I'm not sure I'm the best person to be debugging this.

Never mind, I see that you got this, thanks!

vitalybuka mentioned this in rG56ed64dfa9c7: [sanitizer] Don't expect ABORTING in print-module-map.Mar 5 2021, 7:22 PM

Harbormaster completed remote builds in B92424: Diff 328688.Mar 6 2021, 1:05 PM

Revision Contents

Path

Size

compiler-rt/

test/

sanitizer_common/

TestCases/

Posix/

print-module-map.cpp

9 lines

Diff 328693

compiler-rt/test/sanitizer_common/TestCases/Posix/print-module-map.cpp

	// Checks that module map does not print at 0, prints once after aborting with 1,			// Checks that module map does not print at 0, prints once after aborting with 1,
	// and prints once before and after aborting with 2			// and prints once before and after aborting with 2

	// mac header is "Process module map"			// mac header is "Process module map"
	// other posix header is "Process memory map follows"			// other posix header is "Process memory map follows"
	// windows header is "Dumping process modules" (ignored here)			// windows header is "Dumping process modules" (ignored here)
	// we should consider unifying the message cross platform			// we should consider unifying the message cross platform

	// RUN: %clangxx -DUSING_%tool_name %s -o %t -w			// RUN: %clangxx -DUSING_%tool_name %s -o %t -w

	// RUN: %env_tool_opts="print_module_map=0" not %run %t 2>&1 \| FileCheck %s --check-prefixes=CHECK,CHECK-MM0			// RUN: %env_tool_opts="print_module_map=0:halt_on_error=0" not %run %t 2>&1 \
	// RUN: %env_tool_opts="print_module_map=1" not %run %t 2>&1 \| FileCheck %s --check-prefixes=CHECK,CHECK-MM1			// RUN: \| FileCheck %s --check-prefixes=CHECK,CHECK-MM0
	// RUN: %env_tool_opts="print_module_map=2" not %run %t 2>&1 \| FileCheck %s --check-prefixes=CHECK,CHECK-MM2			// RUN: %env_tool_opts="print_module_map=1:halt_on_error=0" not %run %t 2>&1 \
				// RUN: \| FileCheck %s --check-prefixes=CHECK,CHECK-MM1
				// RUN: %env_tool_opts="print_module_map=2:halt_on_error=0" not %run %t 2>&1 \
				// RUN: \| FileCheck %s --check-prefixes=CHECK,CHECK-MM2

	// tsan support pending rdar://67747473			// tsan support pending rdar://67747473
	// XFAIL: tsan			// XFAIL: tsan

	// FIXME: Add linux support.			// FIXME: Add linux support.
	// XFAIL: msan && linux			// XFAIL: msan && linux

	// FIXME: Add lsan support.			// FIXME: Add lsan support.
	Show All 24 Lines