This is an archive of the discontinued LLVM Phabricator instance.

Differential D98079

[sanitizers] run print module map test run on posix
ClosedPublic

Authored by aralisza on Mar 5 2021, 2:41 PM.

Details

Reviewers
delcypher
vitalybuka
Commits
rG51d8f598ad57: [sanitizers] run print module map test run on posix
Summary

Previously, this test only ran for mac because platforms have different messaging. This diff enables the test for all posix

rdar://75110847

Diff Detail

Event Timeline

aralisza requested review of this revision.Mar 5 2021, 2:41 PM
aralisza created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 2:41 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
aralisza updated this revision to Diff 328656.Mar 5 2021, 2:41 PM

remove oops

aralisza edited the summary of this revision. (Show Details)Mar 5 2021, 2:42 PM
aralisza updated this revision to Diff 328661.Mar 5 2021, 2:58 PM

move to posix

aralisza added a parent revision: D97746: [ubsan] support print_module_map flag in standalone mode.Mar 5 2021, 2:58 PM
aralisza retitled this revision from [sanitizers] run print module map test run on more platforms to [sanitizers] run print module map test run on posix.
aralisza edited the summary of this revision. (Show Details)
aralisza added reviewers: delcypher, vitalybuka.
vitalybuka accepted this revision.Mar 5 2021, 3:01 PM
This revision is now accepted and ready to land.Mar 5 2021, 3:01 PM
This revision was landed with ongoing or failed builds.Mar 5 2021, 3:41 PM
Closed by commit rG51d8f598ad57: [sanitizers] run print module map test run on posix (authored by aralisza). · Explain Why
This revision was automatically updated to reflect the committed changes.
aralisza added a commit: rG51d8f598ad57: [sanitizers] run print module map test run on posix.
Harbormaster completed remote builds in B92400: Diff 328655.Mar 6 2021, 9:26 AM
Harbormaster completed remote builds in B92401: Diff 328656.Mar 6 2021, 9:35 AM
Harbormaster completed remote builds in B92405: Diff 328661.Mar 6 2021, 10:04 AM

Revision Contents

PathSize
compiler-rt/
test/
sanitizer_common/
TestCases/
Darwin/
Darwin/
18 lines

Diff 328656

compiler-rt/test/sanitizer_common/TestCases/Darwin/print-module-map.cpp

  • This file was moved to compiler-rt/test/sanitizer_common/TestCases/print-module-map.cpp.

compiler-rt/test/sanitizer_common/TestCases/print-module-map.cpp

  • This file was moved from compiler-rt/test/sanitizer_common/TestCases/Darwin/print-module-map.cpp.
// Checks that module map does not print at 0, prints once after aborting with 1, // Checks that module map does not print at 0, prints once after aborting with 1,
// and prints once before and after aborting with 2 // and prints once before and after aborting with 2
// mac header is "Process module map"
// posix header is "Process memory map follows"
// windows header is "Dumping process modules"
// using regex "(P|p)rocess (module|memory).*:" to match all three variants
// we should consider unifying the message cross platform
// RUN: %clangxx -DUSING_%tool_name %s -o %t -w // RUN: %clangxx -DUSING_%tool_name %s -o %t -w
// RUN: %env_tool_opts="print_module_map=0" not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-MM0 // RUN: %env_tool_opts="print_module_map=0" not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-MM0
// RUN: %env_tool_opts="print_module_map=1" not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-MM1 // RUN: %env_tool_opts="print_module_map=1" not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-MM1
// RUN: %env_tool_opts="print_module_map=2" not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-MM2 // RUN: %env_tool_opts="print_module_map=2" not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-MM2
// tsan support pending rdar://67747473 // tsan support pending rdar://67747473
// XFAIL: tsan // XFAIL: tsan
Show All 14 Lines#else
volatile int *a = new int[100]; volatile int *a = new int[100];
delete[] a; delete[] a;
global = a[0]; // use-after-free: triggers ASan/TSan report. global = a[0]; // use-after-free: triggers ASan/TSan report.
#endif #endif
return 0; return 0;
} }
// CHECK: SUMMARY: // CHECK: SUMMARY:
// CHECK-MM0-NOT: Process module map: // CHECK-MM0-NOT: {{(P|p)rocess (module|memory).*:}}
// CHECK-MM1-NOT: Process module map: // CHECK-MM1-NOT: {{(P|p)rocess (module|memory).*:}}
// CHECK-MM2: Process module map: // CHECK-MM2: {{(P|p)rocess (module|memory).*:}}
// CHECK: ABORTING // CHECK: ABORTING
// CHECK-MM0-NOT: Process module map: // CHECK-MM0-NOT: {{(P|p)rocess (module|memory).*:}}
// CHECK-MM1-NEXT: Process module map: // CHECK-MM1-NEXT: {{(P|p)rocess (module|memory).*:}}
// CHECK-MM2-NEXT: Process module map: // CHECK-MM2-NEXT: {{(P|p)rocess (module|memory).*:}}