This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] FuzzedDataProvider: Add missing include
ClosedPublic

Authored by MarcoFalke on Mar 5 2021, 9:57 AM.

Details

Summary

Currently it is not possible to compile the header due to a missing include:

FuzzedDataProvider.h:194:38: error: ‘numeric_limits’ is not a member of ‘std’
  194 |   return ConsumeIntegralInRange(std::numeric_limits<T>::min(),
      |                                      ^~~~~~~~~~~~~~

std::numeric_limits is defined in the header <limits> (See https://en.cppreference.com/w/cpp/types/numeric_limits )

Thus, add the missing include.

Diff Detail

Event Timeline

MarcoFalke created this revision.Mar 5 2021, 9:57 AM
MarcoFalke requested review of this revision.Mar 5 2021, 9:57 AM
MarcoFalke set the repository for this revision to rG LLVM Github Monorepo.
MarcoFalke added a project: Restricted Project.
Herald added a subscriber: Restricted Project. · View Herald TranscriptMar 5 2021, 9:59 AM

@Dor1s I can commit this myself, but it needs one approval first. Mind taking a look?

The gcc version I used (if relevant):

gcc (GCC) 11.0.0 20210210 (Red Hat 11.0.0-0)
This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2021, 3:27 AM
This revision was automatically updated to reflect the committed changes.

I merged this before review because without the patch we are unable to compile and it should be trivially correct. Feel free to revert if there are any issues with it.