This is an archive of the discontinued LLVM Phabricator instance.

Differential D97959

[HIP] do not use -mconstructor-aliases for device
ClosedPublic

Authored by yaxunl on Mar 4 2021, 8:51 AM.

Details

Reviewers
tra
Commits
rG258ecf5f33e7: [HIP] do not use -mconstructor-aliases for device
Summary

Like nvptx and some other targets, -mconstructor-aliases does not work well with amdgpu,
therefore we disable it in the same approach.

Diff Detail

Event Timeline

yaxunl created this revision.Mar 4 2021, 8:51 AM
Herald added a subscriber: tpr. · View Herald TranscriptMar 4 2021, 8:51 AM
yaxunl requested review of this revision.Mar 4 2021, 8:51 AM
tra accepted this revision.Mar 4 2021, 9:23 AM
This revision is now accepted and ready to land.Mar 4 2021, 9:23 AM
Harbormaster completed remote builds in B92089: Diff 327913.Mar 4 2021, 9:55 PM
Closed by commit rG258ecf5f33e7: [HIP] do not use -mconstructor-aliases for device (authored by yaxunl). · Explain WhyMar 5 2021, 5:48 AM
This revision was automatically updated to reflect the committed changes.
yaxunl added a commit: rG258ecf5f33e7: [HIP] do not use -mconstructor-aliases for device.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 5:48 AM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
8 lines
test/
Driver/
7 lines

Diff 328489

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,919 Lines • ▼ Show 20 Lines if (Args.hasArg(options::OPT_fdebug_pass_structure)) {
CmdArgs.push_back("Structure"); CmdArgs.push_back("Structure");
} }
if (Args.hasArg(options::OPT_fdebug_pass_arguments)) { if (Args.hasArg(options::OPT_fdebug_pass_arguments)) {
CmdArgs.push_back("-mdebug-pass"); CmdArgs.push_back("-mdebug-pass");
CmdArgs.push_back("Arguments"); CmdArgs.push_back("Arguments");
} }
// Enable -mconstructor-aliases except on darwin, where we have to work around // Enable -mconstructor-aliases except on darwin, where we have to work around
// a linker bug (see <rdar://problem/7651567>), and CUDA device code, where // a linker bug (see <rdar://problem/7651567>), and CUDA/AMDGPU device code,
// aliases aren't supported. Similarly, aliases aren't yet supported for AIX. // where aliases aren't supported. Similarly, aliases aren't yet supported
if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isOSAIX()) // for AIX.
if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() &&
!RawTriple.isAMDGPU() && !RawTriple.isOSAIX())
CmdArgs.push_back("-mconstructor-aliases"); CmdArgs.push_back("-mconstructor-aliases");
// Darwin's kernel doesn't support guard variables; just die if we // Darwin's kernel doesn't support guard variables; just die if we
// try to use them. // try to use them.
if (KernelOrKext && RawTriple.isOSDarwin()) if (KernelOrKext && RawTriple.isOSDarwin())
CmdArgs.push_back("-fforbid-guard-variables"); CmdArgs.push_back("-fforbid-guard-variables");
if (Args.hasFlag(options::OPT_mms_bitfields, options::OPT_mno_ms_bitfields, if (Args.hasFlag(options::OPT_mms_bitfields, options::OPT_mno_ms_bitfields,
▲ Show 20 Lines • Show All 2,639 Lines • Show Last 20 Lines

clang/test/Driver/hip-options.hip

Show All 34 Lines
// RUN: %clang -### -nogpuinc -nogpulib -munsafe-fp-atomics \ // RUN: %clang -### -nogpuinc -nogpulib -munsafe-fp-atomics \
// RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=UNSAFE-FP-ATOMICS %s // RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=UNSAFE-FP-ATOMICS %s
// UNSAFE-FP-ATOMICS: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-munsafe-fp-atomics" // UNSAFE-FP-ATOMICS: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-munsafe-fp-atomics"
// RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib -fgpu-exclude-wrong-side-overloads \ // RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib -fgpu-exclude-wrong-side-overloads \
// RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=FIX-OVERLOAD %s // RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=FIX-OVERLOAD %s
// FIX-OVERLOAD: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fgpu-exclude-wrong-side-overloads" "-fgpu-defer-diag" // FIX-OVERLOAD: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fgpu-exclude-wrong-side-overloads" "-fgpu-defer-diag"
// FIX-OVERLOAD: clang{{.*}} "-triple" "x86_64-unknown-linux-gnu" {{.*}} "-fgpu-exclude-wrong-side-overloads" "-fgpu-defer-diag" // FIX-OVERLOAD: clang{{.*}} "-triple" "x86_64-unknown-linux-gnu" {{.*}} "-fgpu-exclude-wrong-side-overloads" "-fgpu-defer-diag"
// Check -mconstructor-aliases is not passed to device compilation.
// RUN: %clang -### -target x86_64-unknown-linux-gnu -nogpuinc -nogpulib \
// RUN: --cuda-gpu-arch=gfx906 %s 2>&1 | FileCheck -check-prefix=CTA %s
// CTA: clang{{.*}} "-triple" "x86_64-unknown-linux-gnu" {{.*}} "-mconstructor-aliases"
// CTA-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mconstructor-aliases"