This is an archive of the discontinued LLVM Phabricator instance.

Differential D97931

[asan][test] Handle Solaris in large_func_test.cpp etc.
ClosedPublic

Authored by ro on Mar 4 2021, 4:09 AM.

Details

Reviewers
vitalybuka
Commits
rGab8a46024157: [asan][test] Handle Solaris in large_func_test.cpp etc.
Summary

Two ASan tests currently `FAIL' on Solaris

AddressSanitizer-i386-sunos :: TestCases/large_func_test.cpp
AddressSanitizer-i386-sunos :: TestCases/use-after-delete.cpp

both for the same reason:

error: no check strings found with prefix 'CHECK-SunOS:'

Fixed by adding the appropriate check strings.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

Diff Detail

Event Timeline

ro created this revision.Mar 4 2021, 4:09 AM
Herald added subscribers: pengfei, fedor.sergeev. · View Herald TranscriptMar 4 2021, 4:09 AM
ro requested review of this revision.Mar 4 2021, 4:09 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptMar 4 2021, 4:09 AM
Harbormaster completed remote builds in B92037: Diff 328119.Mar 4 2021, 3:12 PM
vitalybuka accepted this revision.Mar 5 2021, 12:08 PM
This revision is now accepted and ready to land.Mar 5 2021, 12:08 PM
Closed by commit rGab8a46024157: [asan][test] Handle Solaris in large_func_test.cpp etc. (authored by ro). · Explain WhyMar 5 2021, 4:31 PM
This revision was automatically updated to reflect the committed changes.
ro added a commit: rGab8a46024157: [asan][test] Handle Solaris in large_func_test.cpp etc..

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
8 lines
6 lines

Diff 328690

compiler-rt/test/asan/TestCases/large_func_test.cpp

Show All 19 Linesstatic void LargeFunction(int *x, int zero) {
// CHECK: {{.*ERROR: AddressSanitizer: heap-buffer-overflow on address}} // CHECK: {{.*ERROR: AddressSanitizer: heap-buffer-overflow on address}}
// CHECK: {{0x.* at pc 0x.* bp 0x.* sp 0x.*}} // CHECK: {{0x.* at pc 0x.* bp 0x.* sp 0x.*}}
// CHECK: {{READ of size 4 at 0x.* thread T0}} // CHECK: {{READ of size 4 at 0x.* thread T0}}
x[zero + 103]++; // we should report this exact line x[zero + 103]++; // we should report this exact line
// atos incorrectly extracts the symbol name for the static functions on // atos incorrectly extracts the symbol name for the static functions on
// Darwin. // Darwin.
// CHECK-Linux: {{#0 0x.* in LargeFunction.*large_func_test.cpp:}}[[@LINE-3]] // CHECK-Linux: {{#0 0x.* in LargeFunction.*large_func_test.cpp:}}[[@LINE-3]]
// CHECK-Windows:{{#0 0x.* in LargeFunction.*large_func_test.cpp:}}[[@LINE-4]] // CHECK-SunOS: {{#0 0x.* in LargeFunction.*large_func_test.cpp:}}[[@LINE-4]]
// CHECK-Darwin: {{#0 0x.* in .*LargeFunction.*large_func_test.cpp}}:[[@LINE-5]] // CHECK-Windows:{{#0 0x.* in LargeFunction.*large_func_test.cpp:}}[[@LINE-5]]
// CHECK-Darwin: {{#0 0x.* in .*LargeFunction.*large_func_test.cpp}}:[[@LINE-6]]
x[10]++; x[10]++;
x[11]++; x[11]++;
x[12]++; x[12]++;
x[13]++; x[13]++;
x[14]++; x[14]++;
x[15]++; x[15]++;
x[16]++; x[16]++;
x[17]++; x[17]++;
x[18]++; x[18]++;
x[19]++; x[19]++;
} }
int main(int argc, char **argv) { int main(int argc, char **argv) {
int *x = new int[100]; int *x = new int[100];
LargeFunction(x, argc - 1); LargeFunction(x, argc - 1);
// CHECK: {{ #1 0x.* in main .*large_func_test.cpp:}}[[@LINE-1]] // CHECK: {{ #1 0x.* in main .*large_func_test.cpp:}}[[@LINE-1]]
// CHECK: {{0x.* is located 12 bytes to the right of 400-byte region}} // CHECK: {{0x.* is located 12 bytes to the right of 400-byte region}}
// CHECK: {{allocated by thread T0 here:}} // CHECK: {{allocated by thread T0 here:}}
// CHECK-Linux: {{ #0 0x.* in operator new}} // CHECK-Linux: {{ #0 0x.* in operator new}}
// CHECK-SunOS: {{ #0 0x.* in operator new}}
// CHECK-Windows:{{ #0 0x.* in operator new}} // CHECK-Windows:{{ #0 0x.* in operator new}}
// CHECK-Darwin: {{ #0 0x.* in .*_Zna}} // CHECK-Darwin: {{ #0 0x.* in .*_Zna}}
// CHECK: {{ #1 0x.* in main .*large_func_test.cpp:}}[[@LINE-8]] // CHECK: {{ #1 0x.* in main .*large_func_test.cpp:}}[[@LINE-9]]
delete[] x; delete[] x;
} }

compiler-rt/test/asan/TestCases/use-after-delete.cpp

Show All 11 Linesint main() {
// CHECK: {{.*ERROR: AddressSanitizer: heap-use-after-free on address}} // CHECK: {{.*ERROR: AddressSanitizer: heap-use-after-free on address}}
// CHECK: {{0x.* at pc 0x.* bp 0x.* sp 0x.*}} // CHECK: {{0x.* at pc 0x.* bp 0x.* sp 0x.*}}
// CHECK: {{READ of size 1 at 0x.* thread T0}} // CHECK: {{READ of size 1 at 0x.* thread T0}}
// CHECK: {{ #0 0x.* in main .*use-after-delete.cpp:}}[[@LINE-4]] // CHECK: {{ #0 0x.* in main .*use-after-delete.cpp:}}[[@LINE-4]]
// CHECK: {{0x.* is located 5 bytes inside of 10-byte region .0x.*,0x.*}} // CHECK: {{0x.* is located 5 bytes inside of 10-byte region .0x.*,0x.*}}
// CHECK: {{freed by thread T0 here:}} // CHECK: {{freed by thread T0 here:}}
// CHECK-Linux: {{ #0 0x.* in operator delete\[\]}} // CHECK-Linux: {{ #0 0x.* in operator delete\[\]}}
// CHECK-SunOS: {{ #0 0x.* in operator delete\[\]}}
// CHECK-Windows:{{ #0 0x.* in operator delete\[\]}} // CHECK-Windows:{{ #0 0x.* in operator delete\[\]}}
// CHECK-Darwin: {{ #0 0x.* in .*_Zda}} // CHECK-Darwin: {{ #0 0x.* in .*_Zda}}
// CHECK: {{ #1 0x.* in main .*use-after-delete.cpp:}}[[@LINE-12]] // CHECK: {{ #1 0x.* in main .*use-after-delete.cpp:}}[[@LINE-13]]
// CHECK: {{previously allocated by thread T0 here:}} // CHECK: {{previously allocated by thread T0 here:}}
// CHECK-Linux: {{ #0 0x.* in operator new\[\]}} // CHECK-Linux: {{ #0 0x.* in operator new\[\]}}
// CHECK-SunOS: {{ #0 0x.* in operator new\[\]}}
// CHECK-Windows:{{ #0 0x.* in operator new\[\]}} // CHECK-Windows:{{ #0 0x.* in operator new\[\]}}
// CHECK-Darwin: {{ #0 0x.* in .*_Zna}} // CHECK-Darwin: {{ #0 0x.* in .*_Zna}}
// CHECK: {{ #1 0x.* in main .*use-after-delete.cpp:}}[[@LINE-19]] // CHECK: {{ #1 0x.* in main .*use-after-delete.cpp:}}[[@LINE-21]]
// CHECK: Shadow byte legend (one shadow byte represents {{[0-9]+}} application bytes): // CHECK: Shadow byte legend (one shadow byte represents {{[0-9]+}} application bytes):
// CHECK: Global redzone: // CHECK: Global redzone:
// CHECK: ASan internal: // CHECK: ASan internal:
} }