This is an archive of the discontinued LLVM Phabricator instance.

[lld/mac] Prefix errors with "ld64.lld" instead of just "lld"
ClosedPublic

Authored by thakis on Mar 1 2021, 11:46 AM.

Details

Reviewers
int3
Group Reviewers
Restricted Project
Commits
rGbacacb9d5c97: [lld/mac] Prefix errors with "ld64.lld" instead of just "lld"
Summary

Matches the ELF and COFF ports, which use ld.lld and lld-link, respectively.

While here, also move up cleanupCallback to match ELF / COFF.

Diff Detail

Event Timeline

thakis created this revision.Mar 1 2021, 11:46 AM
Herald added a project: Restricted Project. · View Herald Transcript
thakis requested review of this revision.Mar 1 2021, 11:46 AM
int3 accepted this revision.Mar 1 2021, 11:50 AM
This revision is now accepted and ready to land.Mar 1 2021, 11:50 AM
This revision was landed with ongoing or failed builds.Mar 1 2021, 12:08 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2021, 12:08 PM

@int3 please include some text when approving patches in Phab - otherwise Phab doesn't send email to the list, making it look like patches are being submitted without approval.

int3 added a comment.Mar 1 2021, 4:24 PM

Oh I had no idea. Will keep that in mind