Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[profile] Delete unused __llvm_profile_write_buffer_internal

Authored by MaskRay on Feb 28 2021, 2:56 PM.



Unused since D14692 (2015).

Diff Detail

Event Timeline

MaskRay requested review of this revision.Feb 28 2021, 2:56 PM
MaskRay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2021, 2:56 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

not sure if one is used by downstream users -- on the other hand if is used, the name of the API should be changed.

vsk added a comment.Mar 1 2021, 8:23 AM

The API isn't unused. We have low-level projects at Apple (xnu, various bits of firmware) that rely on it.

vsk added a comment.Mar 1 2021, 8:58 AM

The API is missing test coverage. I sent a patch adding some here:

MaskRay abandoned this revision.Mar 1 2021, 10:43 AM