This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Use the native path types in path.compare
ClosedPublic

Authored by mstorsjo on Feb 26 2021, 6:09 AM.

Details

Summary

This makes sure that it actually tests the right compare() overloads in windows configurations.

This also fixes the allocation guards that enforce no allocations while running the compare() functions.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Feb 26 2021, 6:09 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2021, 6:09 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
curdeius accepted this revision.Feb 26 2021, 8:25 AM

Great! LGTM. Thanks for fixing that.

ldionne accepted this revision.Mar 1 2021, 10:44 AM
This revision is now accepted and ready to land.Mar 1 2021, 10:44 AM