[libcxx] [test] Use string().c_str() to convert a std::filesystem::path to a const char*

[mstorsjo]

Summary

On Windows, path::value_type is wchar_t, so one can't pass the return value of path::c_str() directly to std::remove().

This matches what was done for tests under std/input.output/filesystems in 81db3c31aafec72f1cfec2a9da4381ece7f97a29 and 3784bdf2176f38cc30134fab776efb43506c0c54.

[curdeius]

LGTM.

libcxx/test/std/input.output/file.streams/fstreams/filebuf.members/open_path.pass.cpp

int main(int, char**) {
   {
     std::filebuf f;
     assert(f.open(p, std::ios_base::in) != 0);
     assert(f.is_open());
     assert(f.sbumpc() == '1');
     assert(f.sbumpc() == '2');
     assert(f.sbumpc() == '3');
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
   {
     std::wfilebuf f;
     assert(f.open(p, std::ios_base::out) != 0);
     assert(f.is_open());
     assert(f.sputn(L"123", 3) == 3);
   }
   {
     std::wfilebuf f;
     assert(f.open(p, std::ios_base::in) != 0);
     assert(f.is_open());
     assert(f.sbumpc() == L'1');
     assert(f.sbumpc() == L'2');
     assert(f.sbumpc() == L'3');
   }
-  remove(p.c_str());
+  remove(p.string().c_str());
 
   return 0;
 }

libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/path.pass.cpp

fs::path p = get_temp_file_name();
     std::fstream fs(p, std::ios_base::in | std::ios_base::out |
                            std::ios_base::trunc);
     double x = 0;
     fs << 3.25;
     fs.seekg(0);
     fs >> x;
     assert(x == 3.25);
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
   {
     std::wfstream fs(p, std::ios_base::in | std::ios_base::out |
                             std::ios_base::trunc);
     double x = 0;
     fs << 3.25;
     fs.seekg(0);
     fs >> x;
     assert(x == 3.25);
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
 
   return 0;
 }

libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_path.pass.cpp

stream.open(p,
                 std::ios_base::in | std::ios_base::out | std::ios_base::trunc);
     assert(stream.is_open());
     double x = 0;
     stream << 3.25;
     stream.seekg(0);
     stream >> x;
     assert(x == 3.25);
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
   {
     std::wfstream stream;
     assert(!stream.is_open());
     stream.open(p,
                 std::ios_base::in | std::ios_base::out | std::ios_base::trunc);
     assert(stream.is_open());
     double x = 0;
     stream << 3.25;
     stream.seekg(0);
     stream >> x;
     assert(x == 3.25);
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
 
   return 0;
 }

libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/path.pass.cpp

fs::path p = get_temp_file_name();
     assert(x == 3.25);
   }
   {
     std::ifstream stream(p, std::ios_base::out);
     double x = 0;
     stream >> x;
     assert(x == 3.25);
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
   {
     std::wofstream stream(p);
     stream << 3.25;
   }
   {
     std::wifstream stream(p);
     double x = 0;
     stream >> x;
     assert(x == 3.25);
   }
   {
     std::wifstream stream(p, std::ios_base::out);
     double x = 0;
     stream >> x;
     assert(x == 3.25);
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
 
   return 0;
 }

libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_path.pass.cpp

fs::path p = get_temp_file_name();
     fs << c;
   }
   {
     std::ifstream fs(p.c_str());
     char c = 0;
     fs >> c;
     assert(c == 'a');
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
   {
     std::wofstream fs;
     assert(!fs.is_open());
     wchar_t c = L'a';
     fs << c;
     assert(fs.fail());
     fs.open(p);
     assert(fs.is_open());
     fs << c;
   }
   {
     std::wifstream fs(p.c_str());
     wchar_t c = 0;
     fs >> c;
     assert(c == L'a');
   }
-  std::remove(p.c_str());
+  std::remove(p.string().c_str());
 
   return 0;
 }