Page MenuHomePhabricator

[debugserver] Fix logic to extract app bundle from file path

Authored by JDevlieghere on Feb 24 2021, 10:19 PM.



Fix the logic to find the app bundle in a path by correctly accounting for paths containing multiple occurrences of .app. The new logic will correctly extract from


Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Feb 24 2021, 10:19 PM
JDevlieghere created this revision.
jasonmolenda accepted this revision.Feb 24 2021, 10:37 PM

Nice, LGTM.


I wouldn't conditionalize these messages on LOG_PROCESS, I would log unconditionally if the app launch failed (just DNBLog the errors, IMO)

This revision is now accepted and ready to land.Feb 24 2021, 10:37 PM
This revision was landed with ongoing or failed builds.Feb 24 2021, 11:08 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2021, 11:08 PM