Page MenuHomePhabricator

Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI)
ClosedPublic

Authored by ki.stfu on May 13 2015, 5:32 AM.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 25675.May 13 2015, 5:32 AM
ki.stfu retitled this revision from to Add MiSyntaxTestCase.test_lldbmi_output_grammar test (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added a reviewer: abidh.
ki.stfu added subscribers: abidh, Unknown Object (MLST).

Friendly ping.

Friendly ping.

dawn added a subscriber: dawn.Jun 29 2015, 3:52 PM
ki.stfu updated this revision to Diff 30784.Jul 27 2015, 10:55 PM

Rebase against ToT

I plan to commit it this week. Does anyone has any objections?

abidh requested changes to this revision.Jul 28 2015, 2:05 AM
abidh edited edge metadata.

This test is failing on Linux. I am trying to understand how this test is supposed to work. Please add some more comments and then I can debug why it is failing on Linux.

test/tools/lldb-mi/syntax/TestMiSyntax.py
108 ↗(On Diff #30784)

This is not being used.

114 ↗(On Diff #30784)

Add some comments to describe what these functions are meant to do.

116 ↗(On Diff #30784)

What it means to be in command state?

tools/lldb-mi/MIDriver.cpp
607

You can commit this line separately. It does not seem to related to this patch.

This revision now requires changes to proceed.Jul 28 2015, 2:05 AM
ki.stfu added inline comments.Jul 28 2015, 2:25 AM
test/tools/lldb-mi/syntax/TestMiSyntax.py
108 ↗(On Diff #30784)

It refers to line #156. I may add an assert(matched_pattern == error) there.

116 ↗(On Diff #30784)

That lldb-mi has nothing to do until we type a next command. For example, after lldb-mi startup.

tools/lldb-mi/MIDriver.cpp
607

It causes a failure of the added test.

ki.stfu updated this revision to Diff 70977.Sep 11 2016, 11:53 PM
ki.stfu edited edge metadata.

Rebase against ToT

ki.stfu updated this revision to Diff 70979.Sep 12 2016, 12:12 AM
ki.stfu marked 6 inline comments as done.
ki.stfu edited edge metadata.

Rebase against ToT; Apply autopep8

This revision was automatically updated to reflect the committed changes.
ki.stfu marked an inline comment as done.