This is an archive of the discontinued LLVM Phabricator instance.

Paths

[AVR] Fix operands for ASRW8Rd
AbandonedPublic

Authored by aykevl on Feb 21 2021, 4:47 PM.

Reviewers

dylanmckay
benshi001

Summary

The second (instead of the first) operand was set as the definition for the ADDRdRr instruction.

This issue was flagged by the machine verifier.

aykevl requested review of this revision.Feb 21 2021, 4:47 PM

Let's merge this with D97159.

Path

Size

llvm/

lib/

Target/

AVR/

5 lines

	Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
	TRI->splitReg(DstReg, DstLoReg, DstHiReg);			TRI->splitReg(DstReg, DstLoReg, DstHiReg);

	// Move upper byte to lower byte.			// Move upper byte to lower byte.
	buildMI(MBB, MBBI, AVR::MOVRdRr)			buildMI(MBB, MBBI, AVR::MOVRdRr)
	.addReg(DstLoReg, RegState::Define \| getDeadRegState(DstIsDead))			.addReg(DstLoReg, RegState::Define \| getDeadRegState(DstIsDead))
	.addReg(DstHiReg);			.addReg(DstHiReg);

	// Move the sign bit to the C flag.			// Move the sign bit to the C flag.
	buildMI(MBB, MBBI, AVR::ADDRdRr).addReg(DstHiReg)			buildMI(MBB, MBBI, AVR::ADDRdRr)
	.addReg(DstHiReg, RegState::Define \| getDeadRegState(DstIsDead))			.addReg(DstHiReg, RegState::Define, getDeadRegState(DstIsDead))
				.addReg(DstHiReg, getKillRegState(DstIsKill) \| getDeadRegState(DstIsDead))
	.addReg(DstHiReg, getKillRegState(DstIsKill));			.addReg(DstHiReg, getKillRegState(DstIsKill));

	// Set upper byte to 0 or -1.			// Set upper byte to 0 or -1.
	auto MIBHI =			auto MIBHI =
	buildMI(MBB, MBBI, AVR::SBCRdRr)			buildMI(MBB, MBBI, AVR::SBCRdRr)
	.addReg(DstHiReg, RegState::Define \| getDeadRegState(DstIsDead))			.addReg(DstHiReg, RegState::Define \| getDeadRegState(DstIsDead))
	.addReg(DstHiReg, getKillRegState(DstIsKill))			.addReg(DstHiReg, getKillRegState(DstIsKill))
	.addReg(DstHiReg, getKillRegState(DstIsKill));			.addReg(DstHiReg, getKillRegState(DstIsKill));
	▲ Show 20 Lines • Show All 363 Lines • Show Last 20 Lines