This is an archive of the discontinued LLVM Phabricator instance.

Differential D96888

[NFC][clang] Bump up DIAG_SIZE_SEMA for downstream diagnostics
ClosedPublic

Authored by zixuw on Feb 17 2021, 11:54 AM.

Details

Reviewers
None
Commits
rGe320cf23f093: [NFC][clang] Bump up DIAG_SIZE_SEMA for downstream diagnostics
Summary

Bump DIAG_SIZE_SEMA up by 500 to accommodate extra downstream diagnostics

Diff Detail

Event Timeline

zixuw requested review of this revision.Feb 17 2021, 11:54 AM
zixuw created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 11:54 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2021, 11:56 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGe320cf23f093: [NFC][clang] Bump up DIAG_SIZE_SEMA for downstream diagnostics (authored by zixuw). · Explain Why
This revision was automatically updated to reflect the committed changes.
zixuw added a commit: rGe320cf23f093: [NFC][clang] Bump up DIAG_SIZE_SEMA for downstream diagnostics.
Harbormaster completed remote builds in B89591: Diff 324379.Feb 17 2021, 1:37 PM

Revision Contents

PathSize
clang/
include/
clang/
Basic/
2 lines

Diff 324379

clang/include/clang/Basic/DiagnosticIDs.h

Show All 20 Lines
namespace clang { namespace clang {
class DiagnosticsEngine; class DiagnosticsEngine;
class SourceLocation; class SourceLocation;
// Import the diagnostic enums themselves. // Import the diagnostic enums themselves.
namespace diag { namespace diag {
// Size of each of the diagnostic categories. // Size of each of the diagnostic categories.
enum { enum {
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    enum {
-      DIAG_SIZE_COMMON        =  300,
-      DIAG_SIZE_DRIVER        =  250,
-      DIAG_SIZE_FRONTEND      =  150,
-      DIAG_SIZE_SERIALIZATION =  120,
-      DIAG_SIZE_LEX           =  400,
-      DIAG_SIZE_PARSE         =  600,
-      DIAG_SIZE_AST           =  250,
-      DIAG_SIZE_COMMENT       =  100,
-      DIAG_SIZE_CROSSTU       =  100,

50 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - enum { - DIAG_SIZE_COMMON = 300…
DIAG_SIZE_COMMON = 300, DIAG_SIZE_COMMON = 300,
DIAG_SIZE_DRIVER = 250, DIAG_SIZE_DRIVER = 250,
DIAG_SIZE_FRONTEND = 150, DIAG_SIZE_FRONTEND = 150,
DIAG_SIZE_SERIALIZATION = 120, DIAG_SIZE_SERIALIZATION = 120,
DIAG_SIZE_LEX = 400, DIAG_SIZE_LEX = 400,
DIAG_SIZE_PARSE = 600, DIAG_SIZE_PARSE = 600,
DIAG_SIZE_AST = 250, DIAG_SIZE_AST = 250,
DIAG_SIZE_COMMENT = 100, DIAG_SIZE_COMMENT = 100,
DIAG_SIZE_CROSSTU = 100, DIAG_SIZE_CROSSTU = 100,
DIAG_SIZE_SEMA = 4000, DIAG_SIZE_SEMA = 4500,
DIAG_SIZE_ANALYSIS = 100, DIAG_SIZE_ANALYSIS = 100,
DIAG_SIZE_REFACTORING = 1000, DIAG_SIZE_REFACTORING = 1000,
}; };
// Start position for diagnostics. // Start position for diagnostics.
enum { enum {
DIAG_START_COMMON = 0, DIAG_START_COMMON = 0,
DIAG_START_DRIVER = DIAG_START_COMMON + DIAG_SIZE_COMMON, DIAG_START_DRIVER = DIAG_START_COMMON + DIAG_SIZE_COMMON,
DIAG_START_FRONTEND = DIAG_START_DRIVER + DIAG_SIZE_DRIVER, DIAG_START_FRONTEND = DIAG_START_DRIVER + DIAG_SIZE_DRIVER,
DIAG_START_SERIALIZATION = DIAG_START_FRONTEND + DIAG_SIZE_FRONTEND, DIAG_START_SERIALIZATION = DIAG_START_FRONTEND + DIAG_SIZE_FRONTEND,
DIAG_START_LEX = DIAG_START_SERIALIZATION + DIAG_SIZE_SERIALIZATION, DIAG_START_LEX = DIAG_START_SERIALIZATION + DIAG_SIZE_SERIALIZATION,
DIAG_START_PARSE = DIAG_START_LEX + DIAG_SIZE_LEX, DIAG_START_PARSE = DIAG_START_LEX + DIAG_SIZE_LEX,
DIAG_START_AST = DIAG_START_PARSE + DIAG_SIZE_PARSE, DIAG_START_AST = DIAG_START_PARSE + DIAG_SIZE_PARSE,
DIAG_START_COMMENT = DIAG_START_AST + DIAG_SIZE_AST, DIAG_START_COMMENT = DIAG_START_AST + DIAG_SIZE_AST,
DIAG_START_CROSSTU = DIAG_START_COMMENT + DIAG_SIZE_COMMENT, DIAG_START_CROSSTU = DIAG_START_COMMENT + DIAG_SIZE_COMMENT,
DIAG_START_SEMA = DIAG_START_CROSSTU + DIAG_SIZE_CROSSTU, DIAG_START_SEMA = DIAG_START_CROSSTU + DIAG_SIZE_CROSSTU,
DIAG_START_ANALYSIS = DIAG_START_SEMA + DIAG_SIZE_SEMA, DIAG_START_ANALYSIS = DIAG_START_SEMA + DIAG_SIZE_SEMA,
DIAG_START_REFACTORING = DIAG_START_ANALYSIS + DIAG_SIZE_ANALYSIS, DIAG_START_REFACTORING = DIAG_START_ANALYSIS + DIAG_SIZE_ANALYSIS,
DIAG_UPPER_LIMIT = DIAG_START_REFACTORING + DIAG_SIZE_REFACTORING DIAG_UPPER_LIMIT = DIAG_START_REFACTORING + DIAG_SIZE_REFACTORING
}; };
class CustomDiagInfo; class CustomDiagInfo;
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    class CustomDiagInfo;
+  class CustomDiagInfo;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - class CustomDiagInfo; + class CustomDiagInfo…
/// All of the diagnostics that can be emitted by the frontend. /// All of the diagnostics that can be emitted by the frontend.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    /// All of the diagnostics that can be emitted by the frontend.
-    typedef unsigned kind;
+  /// All of the diagnostics that can be emitted by the frontend.
+  typedef unsigned kind;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// All of the diagnostics that can be emitted…
typedef unsigned kind; typedef unsigned kind;
// Get typedefs for common diagnostics. // Get typedefs for common diagnostics.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    // Get typedefs for common diagnostics.
-    enum {
+  // Get typedefs for common diagnostics.
+  enum {
Lint: Pre-merge checks: clang-format: please reformat the code ``` - // Get typedefs for common diagnostics.
enum { enum {
#define DIAG(ENUM, FLAGS, DEFAULT_MAPPING, DESC, GROUP, SFINAE, CATEGORY, \ #define DIAG(ENUM, FLAGS, DEFAULT_MAPPING, DESC, GROUP, SFINAE, CATEGORY, \
NOWERROR, SHOWINSYSHEADER, DEFFERABLE) \ NOWERROR, SHOWINSYSHEADER, DEFFERABLE) \
ENUM, ENUM,
#define COMMONSTART #define COMMONSTART
#include "clang/Basic/DiagnosticCommonKinds.inc" #include "clang/Basic/DiagnosticCommonKinds.inc"
NUM_BUILTIN_COMMON_DIAGNOSTICS NUM_BUILTIN_COMMON_DIAGNOSTICS
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-      NUM_BUILTIN_COMMON_DIAGNOSTICS
+    NUM_BUILTIN_COMMON_DIAGNOSTICS
Lint: Pre-merge checks: clang-format: please reformat the code ``` - NUM_BUILTIN_COMMON_DIAGNOSTICS +…
#undef DIAG #undef DIAG
}; };
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    };
+  };
Lint: Pre-merge checks: clang-format: please reformat the code ``` - }; + }; ```
/// Enum values that allow the client to map NOTEs, WARNINGs, and EXTENSIONs /// Enum values that allow the client to map NOTEs, WARNINGs, and EXTENSIONs
/// to either Ignore (nothing), Remark (emit a remark), Warning /// to either Ignore (nothing), Remark (emit a remark), Warning
/// (emit a warning) or Error (emit as an error). It allows clients to /// (emit a warning) or Error (emit as an error). It allows clients to
/// map ERRORs to Error or Fatal (stop emitting diagnostics after this one). /// map ERRORs to Error or Fatal (stop emitting diagnostics after this one).
enum class Severity { enum class Severity {
// NOTE: 0 means "uncomputed". // NOTE: 0 means "uncomputed".
Ignored = 1, ///< Do not present this diagnostic, ignore it. Ignored = 1, ///< Do not present this diagnostic, ignore it.
▲ Show 20 Lines • Show All 267 Lines • Show Last 20 Lines