Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

IR: Rename Metadata::ImplicitCode to SubclassData1, NFC

Authored by dexonsmith on Feb 15 2021, 5:51 PM.



Metadata::ImplicitCode is a bit shaved off of Metadata::Storage,
currently only in use by the subclass DILocation. However, the bit isn't
reserved for that purpose. Rename it SubclassData1 to make it clear
that it has nothing to do with Metadata itself (and other subclasses are
free to use it).

As a drive-by, remove an old TODO about exposing bits to subclasses
(looks like that has mostly been done).

No functionality change here.

Diff Detail

Event Timeline

dexonsmith requested review of this revision.Feb 15 2021, 5:51 PM
dexonsmith created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2021, 5:51 PM
aprantl accepted this revision.Feb 17 2021, 9:19 AM
This revision is now accepted and ready to land.Feb 17 2021, 9:19 AM
calixte accepted this revision.Feb 17 2021, 9:21 AM

My I missed this patch.
I'm fine with it: that stuff is useless.