Page MenuHomePhabricator

[lldb] Remove ThreadPlan::ShouldAutoContinue (NFC)
AbandonedPublic

Authored by kastiglione on Feb 14 2021, 11:31 PM.

Details

Reviewers
jingham
Summary

Remove ShouldAutoContinue, implemented in only one subclass.

In ThreadPlanStepOverBreakpoint::ShouldAutoContinue, its return value will always be
the inverse of ShouldStop.

In the one call site of ShouldAutoContinue, its value only matters if ShouldStop is
also true. Since that can never be the case (as above, they'll always be opposite), this
function will never apply, and can be removed.

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 14 2021, 11:31 PM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2021, 11:31 PM
kastiglione edited the summary of this revision. (Show Details)Feb 15 2021, 12:04 AM
kastiglione edited the summary of this revision. (Show Details)Feb 15 2021, 9:32 AM
kastiglione abandoned this revision.Feb 15 2021, 11:34 AM

Even though the tests pass, I see that my logic was flawed. In theory, if autocontinue is true, and MischiefManaged returns true, then previous (parent) plans will be asked whether to ShouldStop. So the semantics of ShouldAutoContinue is whether a later plan wants to override should stop of an earlier plan.