Page MenuHomePhabricator

[lldb] Remove unused ThreadPlan tracer utilities (NFC)
ClosedPublic

Authored by kastiglione on Feb 14 2021, 10:19 AM.

Details

Summary

Delete unused EnableTracer() and SetTracer() functions on Thread. By deleting
these, their ThreadPlan counterparts also become unused.

Then, by deleting ThreadPlanStack::EnableTracer, EnableSingleStep becomes unused.
With no more callers to EnableSingleStep, the value m_single_step is always true and
can be removed as well.

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 14 2021, 10:19 AM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2021, 10:19 AM
jingham accepted this revision.Feb 15 2021, 2:21 PM

At some point I had the idea that there would be a whole plugin architecture where you could add observers on all the stops & steps the lldb's execution control did. But for lldb command line & SB API usages, the scripted thread plans add a more natural way to do this. We probably shouldn't take the tracers out altogether. I used them a couple of times (though admittedly pretty far back in the day) for debugging stepping issues. But we don't need the higher level bindings.

This revision is now accepted and ready to land.Feb 15 2021, 2:21 PM
This revision was landed with ongoing or failed builds.Feb 15 2021, 6:00 PM
This revision was automatically updated to reflect the committed changes.