This is an archive of the discontinued LLVM Phabricator instance.

Differential D96655

[lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan
ClosedPublic

Authored by kastiglione on Feb 13 2021, 2:19 PM.

Details

Reviewers
jingham
Commits
rG47f652d69517: [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan
Summary

Correct Thread::DiscardPlan to call DiscardPlan instead of PopPlan.

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 13 2021, 2:19 PM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2021, 2:19 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B89125: Diff 323574.Feb 13 2021, 2:55 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptFeb 13 2021, 2:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2022, 1:58 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG47f652d69517: [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan (authored by kastiglione). · Explain Why
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rG47f652d69517: [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan.
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2022, 1:58 PM

Revision Contents

PathSize
lldb/
source/
Target/
2 lines

Diff 414492

lldb/source/Target/Thread.cpp

Show First 20 Lines • Show All 1,085 Lines • ▼ Show 20 Linesvoid Thread::PopPlan() {
if (log) { if (log) {
LLDB_LOGF(log, "Popping plan: \"%s\", tid = 0x%4.4" PRIx64 ".", LLDB_LOGF(log, "Popping plan: \"%s\", tid = 0x%4.4" PRIx64 ".",
popped_plan_sp->GetName(), popped_plan_sp->GetThread().GetID()); popped_plan_sp->GetName(), popped_plan_sp->GetThread().GetID());
} }
} }
void Thread::DiscardPlan() { void Thread::DiscardPlan() {
Log *log = GetLog(LLDBLog::Step); Log *log = GetLog(LLDBLog::Step);
ThreadPlanSP discarded_plan_sp = GetPlans().PopPlan(); ThreadPlanSP discarded_plan_sp = GetPlans().DiscardPlan();
LLDB_LOGF(log, "Discarding plan: \"%s\", tid = 0x%4.4" PRIx64 ".", LLDB_LOGF(log, "Discarding plan: \"%s\", tid = 0x%4.4" PRIx64 ".",
discarded_plan_sp->GetName(), discarded_plan_sp->GetName(),
discarded_plan_sp->GetThread().GetID()); discarded_plan_sp->GetThread().GetID());
} }
void Thread::AutoCompleteThreadPlans(CompletionRequest &request) const { void Thread::AutoCompleteThreadPlans(CompletionRequest &request) const {
const ThreadPlanStack &plans = GetPlans(); const ThreadPlanStack &plans = GetPlans();
▲ Show 20 Lines • Show All 930 Lines • Show Last 20 Lines