Page MenuHomePhabricator

[lldb] Fix crash in FormatEntity for mangled-name
ClosedPublic

Authored by kastiglione on Feb 8 2021, 5:40 PM.

Details

Summary

Check a Block pointer before dereferencing.

Using function.mangled-name led to a crash for a frame where the symbol
context had no block info. In my case, the frame's function was a system frame.

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 8 2021, 5:40 PM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 5:40 PM
mib accepted this revision.Feb 8 2021, 5:51 PM

LGTM! Thanks for catching that!

This revision is now accepted and ready to land.Feb 8 2021, 5:51 PM
This revision was landed with ongoing or failed builds.Feb 8 2021, 6:38 PM
This revision was automatically updated to reflect the committed changes.