Page MenuHomePhabricator

[lldb] Minor cleanups to ThreadPlan.h (NFC)

Authored by kastiglione on Feb 8 2021, 9:27 AM.



While learning about ThreadPlan, I did a bit of cleanup:

  • Remove unused code
  • Move functions to protected where applicable
  • Remove virtual for functions that are not overridden

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 8 2021, 9:27 AM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 9:27 AM

This is okay. It seems like CachePlanExplainsStop wasn't used because it's done by hand instead. A better patch might be to stop doing that and use the function instead? But the argument's not terribly compelling either way...

Restore and call CachePlanExplainsStop

  • Make CachePlanExplainsStop private
  • Delete unused GetCachedPlanExplainsStop
This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2021, 1:36 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.