Page MenuHomePhabricator
Differential D96277

[lldb] Minor cleanups to ThreadPlan.h (NFC)
ClosedPublic
Actions

Authored by kastiglione on Feb 8 2021, 9:27 AM.

Details

Reviewers
jingham
Commits
rG606c3be85d92: [lldb] Minor cleanups to ThreadPlan.h (NFC)
Summary

While learning about ThreadPlan, I did a bit of cleanup:

  • Remove unused code
  • Move functions to protected where applicable
  • Remove virtual for functions that are not overridden

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 8 2021, 9:27 AM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 9:27 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B88315: Diff 322143.Feb 8 2021, 10:53 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptFeb 8 2021, 10:53 AM
jingham added a comment.Feb 8 2021, 10:59 AM

This is okay. It seems like CachePlanExplainsStop wasn't used because it's done by hand instead. A better patch might be to stop doing that and use the function instead? But the argument's not terribly compelling either way...

kastiglione updated this revision to Diff 322773.Feb 10 2021, 11:54 AM

Restore and call CachePlanExplainsStop

kastiglione updated this revision to Diff 322779.Feb 10 2021, 12:00 PM
  • Make CachePlanExplainsStop private
  • Delete unused GetCachedPlanExplainsStop
This revision was not accepted when it landed; it landed in state Needs Review.Feb 10 2021, 1:36 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG606c3be85d92: [lldb] Minor cleanups to ThreadPlan.h (NFC) (authored by kastiglione). · Explain Why
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rG606c3be85d92: [lldb] Minor cleanups to ThreadPlan.h (NFC).
Harbormaster completed remote builds in B88689: Diff 322779.Feb 10 2021, 1:41 PM
Harbormaster completed remote builds in B88687: Diff 322773.Feb 10 2021, 1:47 PM

Revision Contents
Changeset List

PathSize
lldb/
include/
lldb/
Target/
55 lines
source/
Target/
2 lines

Diff 322813

View Options

lldb/include/lldb/Target/ThreadPlan.h

Loading...
View Options

lldb/source/Target/ThreadPlan.cpp

Loading...