This is an archive of the discontinued LLVM Phabricator instance.

Differential D96080

[please delete] created too quickly
Needs ReviewPublic

Authored by LukasHanel on Feb 4 2021, 2:38 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Event Timeline

LukasHanel created this revision.Feb 4 2021, 2:38 PM
Herald added a subscriber: nullptr.cpp. · View Herald TranscriptFeb 4 2021, 2:38 PM
LukasHanel requested review of this revision.Feb 4 2021, 2:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 2:38 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B87989: Diff 321569.Feb 4 2021, 2:39 PM
LukasHanel retitled this revision from format to [please delete] created too quickly.Feb 4 2021, 3:10 PM

Revision Contents

PathSize
clang-tools-extra/
clang-tidy/
readability/
15 lines

Diff 321569

clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp

//===--- UselessReturnValueCheck.cpp - clang-tidy //===--- UselessReturnValueCheck.cpp - clang-tidy
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
//-------------------------------===// //-------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
Show All 16 Lines auto Int0Var =
to(varDecl(hasInitializer(IgnInt0)).bind("retvar"))))); to(varDecl(hasInitializer(IgnInt0)).bind("retvar")))));
Finder->addMatcher( Finder->addMatcher(
functionDecl( functionDecl(
isDefinition(), unless(returns(voidType())), unless(hasName("main")), isDefinition(), unless(returns(voidType())), unless(hasName("main")),
unless(cxxMethodDecl(isVirtual())), unless(cxxMethodDecl(isVirtual())),
forEachDescendant( forEachDescendant(
returnStmt(hasReturnValue(Int0Var)).bind("return-to-void")), returnStmt(hasReturnValue(Int0Var)).bind("return-to-void")),
unless(hasDescendant(returnStmt(unless(hasReturnValue(Int0Var))))), unless(hasDescendant(returnStmt(unless(hasReturnValue(Int0Var))))),
unless(hasDescendant( unless(hasDescendant(binaryOperator(
binaryOperator(isAssignmentOperator(), isAssignmentOperator(),
hasLHS(declRefExpr( hasLHS(declRefExpr(to(varDecl(equalsBoundNode("retvar")))))))),
to(varDecl(equalsBoundNode("retvar")))))))), unless(hasDescendant(cxxOperatorCallExpr(
unless(hasDescendant( isAssignmentOperator(),
cxxOperatorCallExpr(isAssignmentOperator(), hasLHS(hasDescendant(
hasLHS(hasDescendant(declRefExpr( declRefExpr(to(varDecl(equalsBoundNode("retvar"))))))))),
to(varDecl(equalsBoundNode("retvar"))))))))),
unless(hasDescendant( unless(hasDescendant(
unaryOperator(hasAnyOperatorName("++", "--", "&"), unaryOperator(hasAnyOperatorName("++", "--", "&"),
hasUnaryOperand(ignoringImplicit(declRefExpr( hasUnaryOperand(ignoringImplicit(declRefExpr(
to(varDecl(equalsBoundNode("retvar")))))))))) to(varDecl(equalsBoundNode("retvar"))))))))))
.bind("function-to-void"), .bind("function-to-void"),
this); this);
} }
Show All 36 Lines