Page MenuHomePhabricator

LukasHanel (Lukas Hänel)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2021, 8:41 AM (10 w, 4 d)

Recent Activity

Feb 16 2021

LukasHanel added a comment to D96082: [clang-tidy] Add 'readability-useless-return-value' check.

A somewhat similar check that would be interesting is a function that returns the same value on all control paths

I think we shouldn't try to design a new, different check in the comments of this MR.

I think it would be better to finalize what to do with this one.

Request further work to also change expressions in all affected TUs? Or close?

Feb 16 2021, 4:58 PM · Restricted Project, Restricted Project
LukasHanel updated the diff for D96082: [clang-tidy] Add 'readability-useless-return-value' check.

Handle the case of a global variable being the "return value"

Feb 16 2021, 4:32 PM · Restricted Project, Restricted Project

Feb 8 2021

LukasHanel added a comment to D96082: [clang-tidy] Add 'readability-useless-return-value' check.

Hi, thanks for discussing my proposal!

  • Usefulness of the fix-it's

I agree with @njames93 that this check is dangerous. Even if you extended it to port callExprs, that would only work in translation units which can see the definition.

Are you saying I should just remove the fix-its altogether?
Or, put them under some option that is off by default?

Feb 8 2021, 10:37 PM · Restricted Project, Restricted Project

Feb 5 2021

LukasHanel added a comment to D96082: [clang-tidy] Add 'readability-useless-return-value' check.

Hi, thanks for discussing my proposal!
Although I think it can stand as is, I was looking for feedback:

  • Is the name good?
  • Is the readability group good? Or better in misc?
  • too slow, too fast?
  • More precision required?
  • Usefulness of the fix-it's
  • Should I add options?
Feb 5 2021, 11:43 AM · Restricted Project, Restricted Project
LukasHanel added a comment to D96082: [clang-tidy] Add 'readability-useless-return-value' check.

Thanks for the review!

Feb 5 2021, 5:10 AM · Restricted Project, Restricted Project
LukasHanel updated the diff for D96082: [clang-tidy] Add 'readability-useless-return-value' check.

Address review comments, fix C++ unit tests

Feb 5 2021, 5:04 AM · Restricted Project, Restricted Project

Feb 4 2021

LukasHanel added a reviewer for D96082: [clang-tidy] Add 'readability-useless-return-value' check: steveire.
Feb 4 2021, 3:27 PM · Restricted Project, Restricted Project
LukasHanel updated the summary of D96082: [clang-tidy] Add 'readability-useless-return-value' check.
Feb 4 2021, 3:23 PM · Restricted Project, Restricted Project
LukasHanel updated the summary of D96082: [clang-tidy] Add 'readability-useless-return-value' check.
Feb 4 2021, 3:19 PM · Restricted Project, Restricted Project
LukasHanel updated the summary of D96082: [clang-tidy] Add 'readability-useless-return-value' check.
Feb 4 2021, 3:18 PM · Restricted Project, Restricted Project
LukasHanel retitled D96080: [please delete] created too quickly from format to [please delete] created too quickly.
Feb 4 2021, 3:10 PM · Restricted Project
LukasHanel updated the diff for D96082: [clang-tidy] Add 'readability-useless-return-value' check.

Add the real changes

Feb 4 2021, 3:08 PM · Restricted Project, Restricted Project
LukasHanel requested review of D96082: [clang-tidy] Add 'readability-useless-return-value' check.
Feb 4 2021, 3:07 PM · Restricted Project, Restricted Project
LukasHanel requested review of D96080: [please delete] created too quickly.
Feb 4 2021, 2:38 PM · Restricted Project