Support compatibility with buildbot 2.10.

[stevanradakovic]

Summary

This removes the deprecation warning and removes the
non-existing method addFactoryArguments (it was not doing
anything anyway for quite some time) which was breaking
the master.

[gkistanova]

Thanks, Stevan!

[stevanradakovic]

In D95867#2550315, @gkistanova wrote:

Thanks, Stevan!

Thanks for the review Galina! I don't believe I have commit access so it's be great if you can commit this one please.
Cheers.

[maxim-kuvyrkov]

@stevanradakovic ,
@gkistanova ,

I've merged this on Stevan's behalf. Thanks, Stevan!

zorg/buildbot/commands/LitTestCommand.py

 import re
 from os.path import basename
 
 from buildbot.process.results import SUCCESS
 from buildbot.process.results import FAILURE
 
-from buildbot.steps.shell import Test
+from buildbot.steps.shell import TestNewStyle
 
 from buildbot.process.logobserver import LogLineObserver
 
 class LitLogObserver(LogLineObserver):
   # Regular expressions for a regular test line.
   kTestLineRE = re.compile(r'(\w+): (.*) \(.*\)')
 
   # Regular expressions for verbose log start and stop markers. Verbose log
if self.parserStarted is True:
       # Check for a new test status line.
       m = self.kTestLineRE.match(line.strip())
       if m:
         # Remember the last test result and update the result counts.
         self.lastTestResult = (code, name) = m.groups()
         self.resultCounts[code] = self.resultCounts.get(code, 0) + 1
         return
 
-class LitTestCommand(Test):
+class LitTestCommand(TestNewStyle):
   resultNames = {'FAIL':'unexpected failures',
                  'PASS':'expected passes',
                  'XFAIL':'expected failures',
                  'XPASS':'unexpected passes',
                  'KFAIL':'known failures',
                  'KPASS':'unknown passes',
                  'UNRESOLVED':'unresolved testcases',
                  'UNTESTED':'untested testcases',
                  'REGRESSED':'runtime performance regression',
                  'IMPROVED':'runtime performance improvement',
                  'UNSUPPORTED':'unsupported tests',
                  'TIMEOUT':'timeout waiting for results'}
 
   def __init__(self, ignore=[], flaky=[], max_logs=20, parseSummaryOnly=False,
                *args, **kwargs):
     super().__init__(*args, **kwargs)
     self.maxLogs = int(max_logs)
     self.logObserver = LitLogObserver(self.maxLogs, parseSummaryOnly)
-    self.addFactoryArguments(max_logs=max_logs)
-    self.addFactoryArguments(parseSummaryOnly=parseSummaryOnly)
     self.addLogObserver('stdio', self.logObserver)
 
   def evaluateCommand(self, cmd):
     # Always report failure if the command itself failed.
     if cmd.rc != 0:
       return FAILURE
 
     # Otherwise, report failure if there were failures in the log.
     if self.logObserver.hadFailure():
       return FAILURE
 
     return SUCCESS
 
   def describe(self, done=False):
-    description = Test.describe(self, done) or list()
+    description = TestNewStyle.describe(self, done) or list()
     for name, count in self.logObserver.resultCounts.items():
         if name in self.resultNames:
             description.append('{0} {1}'.format(count, self.resultNames[name]))
         else:
             description.append('Unexpected test result output ' + name)
     return description