Have lldb_assert accept bool expressions

[labath]

Summary

This changes lldb_assert to accept bool expressions as the parameter, this is because some
objects (such as std::shared_ptr) are convertible to bool, but are not convertible to int, which
leads to surprising errors.

[granata.enrico]

LGTM

• Enrico

include/lldb/Utility/LLDBAssert.h

 #ifdef LLDB_CONFIGURATION_DEBUG
 #define lldbassert(x) assert(x)
 #else
 #define lldbassert(x) lldb_private::lldb_assert(x, #x, __FUNCTION__, __FILE__, __LINE__)
 #endif
 
 namespace lldb_private {
     void
-    lldb_assert (int expression,
+    lldb_assert (bool expression,
                  const char* expr_text,
                  const char* func,
                  const char* file,
                  unsigned int line);
 }
 
 #endif // utility_LLDBAssert_h_

source/Utility/LLDBAssert.cpp

 #include "llvm/Support/Format.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/Support/Signals.h"
 
 using namespace llvm;
 using namespace lldb_private;
 
 void
-lldb_private::lldb_assert (int expression,
+lldb_private::lldb_assert (bool expression,
                            const char* expr_text,
                            const char* func,
                            const char* file,
                            unsigned int line)
 {
     if (expression)
         ;
     else
     {
         errs() << format("Assertion failed: (%s), function %s, file %s, line %u\n",
                    expr_text, func, file, line);
         errs() << "backtrace leading to the failure:\n";
         llvm::sys::PrintStackTrace(errs());
         errs() << "please file a bug report against lldb reporting this failure log, and as many details as possible\n";
     }
 }