This is an archive of the discontinued LLVM Phabricator instance.

Differential D95646

[libc][NFC] Add a few casts to suppress loss of precision warnings
ClosedPublic

Authored by michaelrj on Jan 28 2021, 3:55 PM.

Details

Reviewers
sivachandra
Commits
rGd4eea5cf0f5d: [libc][NFC] Add a few casts to suppress loss of precision warnings

Diff Detail

Event Timeline

michaelrj created this revision.Jan 28 2021, 3:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2021, 3:55 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Jan 28 2021, 3:55 PM
Harbormaster completed remote builds in B87084: Diff 319980.Jan 28 2021, 4:27 PM
sivachandra accepted this revision.Jan 28 2021, 4:44 PM
sivachandra added inline comments.
libc/utils/FPUtil/x86_64/FEnv.h
295–296

To make it absolutely clear, make it uint16_t(0x3).

This revision is now accepted and ready to land.Jan 28 2021, 4:44 PM
sivachandra retitled this revision from [libc][NFC] add static casts to fenv to [libc][NFC] Add a few casts to suppress loss of precision warnings.Jan 28 2021, 4:45 PM
sivachandra edited the summary of this revision. (Show Details)
michaelrj updated this revision to Diff 320003.Jan 28 2021, 4:56 PM
michaelrj marked an inline comment as done.

clarify the type for the constant being shifted

This revision was landed with ongoing or failed builds.Jan 28 2021, 5:16 PM
Closed by commit rGd4eea5cf0f5d: [libc][NFC] Add a few casts to suppress loss of precision warnings (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGd4eea5cf0f5d: [libc][NFC] Add a few casts to suppress loss of precision warnings.
Harbormaster completed remote builds in B87095: Diff 320003.Jan 28 2021, 6:11 PM

Revision Contents

PathSize
libc/
utils/
FPUtil/
x86_64/
10 lines

Diff 320009

libc/utils/FPUtil/x86_64/FEnv.h

Show First 20 Lines • Show All 284 Lines • ▼ Show 20 Lines case FE_UPWARD:
break; break;
case FE_TOWARDZERO: case FE_TOWARDZERO:
bitValue = internal::RoundingControlValue::TowardZero; bitValue = internal::RoundingControlValue::TowardZero;
break; break;
default: default:
return 1; // To indicate failure return 1; // To indicate failure
} }
uint16_t x87Value = bitValue << internal::X87RoundingControlBitPosition; uint16_t x87Value = static_cast<uint16_t>(
bitValue << internal::X87RoundingControlBitPosition);
uint16_t x87Control = internal::getX87ControlWord(); uint16_t x87Control = internal::getX87ControlWord();
x87Control = x87Control = static_cast<uint16_t>(
sivachandraUnsubmitted
Done
ReplyInline Actions

To make it absolutely clear, make it uint16_t(0x3).

sivachandra: To make it absolutely clear, make it `uint16_t(0x3)`.
(x87Control & ~(0x3 << internal::X87RoundingControlBitPosition)) | (x87Control &
x87Value; ~(uint16_t(0x3) << internal::X87RoundingControlBitPosition)) |
x87Value);
internal::writeX87ControlWord(x87Control); internal::writeX87ControlWord(x87Control);
uint32_t mxcsrValue = bitValue << internal::MXCSRRoundingControlBitPosition; uint32_t mxcsrValue = bitValue << internal::MXCSRRoundingControlBitPosition;
uint32_t mxcsrControl = internal::getMXCSR(); uint32_t mxcsrControl = internal::getMXCSR();
mxcsrControl = mxcsrControl =
(mxcsrControl & ~(0x3 << internal::MXCSRRoundingControlBitPosition)) | (mxcsrControl & ~(0x3 << internal::MXCSRRoundingControlBitPosition)) |
mxcsrValue; mxcsrValue;
internal::writeMXCSR(mxcsrControl); internal::writeMXCSR(mxcsrControl);
return 0; return 0;
} }
} // namespace fputil } // namespace fputil
} // namespace __llvm_libc } // namespace __llvm_libc
#endif // LLVM_LIBC_UTILS_FPUTIL_X86_64_FENV_H #endif // LLVM_LIBC_UTILS_FPUTIL_X86_64_FENV_H