Page MenuHomePhabricator

[External][SPEC2000] Introspect -zmuldefs linker option before use.
ClosedPublic

Authored by Meinersbur on Jan 26 2021, 9:35 PM.

Details

Summary

D95276 unconditionally added the -zmuldefs which is not supported by all linkers. Check whether the compiler/linker accept the flags before using.

Diff Detail

Repository
rT test-suite

Event Timeline

Meinersbur created this revision.Jan 26 2021, 9:35 PM
Meinersbur requested review of this revision.Jan 26 2021, 9:35 PM
fhahn accepted this revision.Jan 27 2021, 2:41 AM

LGTM, thanks!

I also verified this fixes the issues on Darwin platforms locally.

This revision is now accepted and ready to land.Jan 27 2021, 2:41 AM
  • Put check_c_source_compiles into function to keep CMAKE_REQUIRED_LINK_OPTIONS in scope
  • LINKER_MULTIDEF_FLAGS typo