The zx_vmar_op_range allows us to decommit memory pages without
needing a handle to the underlying vmo, as long as we have a handle to
a vmar that contains this mapping. This allows us to implement the
ReleaseMemoryPagesToOS function by decommitting the memory using a
handle to the root vmar.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
compiler-rt/lib/sanitizer_common/sanitizer_fuchsia.cpp | ||
---|---|---|
393 | Note that this will crash if zx_vmar_op_range fails, which is something that the other implementations don't check. |
Comment Actions
lgtm. I think it should only fail if the VMAR handle is bad or doesn't have WRITE rights or if the address range includes non-writable mappings. I think panic is desirable for those cases.
Note that this will crash if zx_vmar_op_range fails, which is something that the other implementations don't check.