Page MenuHomePhabricator

Follow up build fix for P0655R1 visit<R>: Explicit Return Type for visit
ClosedPublic

Authored by rarutyun on Jan 25 2021, 9:20 AM.

Details

Diff Detail

Event Timeline

rarutyun requested review of this revision.Jan 25 2021, 9:20 AM
rarutyun created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 25 2021, 9:20 AM
ldionne accepted this revision.Jan 25 2021, 9:32 AM

Will commit once CI passes.

This revision is now accepted and ready to land.Jan 25 2021, 9:32 AM

Ah, now I understand. This change is necessary to fix the build after https://reviews.llvm.org/D92044. The problem is that CI didn't run for that revision, so we didn't catch the failure. When you submit a patch, please make sure to follow the arc diff instructions here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line.

Using arc diff makes sure that the right repository is populated in the Phabricator revision, and that allows CI to run. I know it's easy to miss (and would love for a more robust setup), but that's what we have for now. :-) I'll check this in now.

This revision was landed with ongoing or failed builds.Jan 25 2021, 10:41 AM
This revision was automatically updated to reflect the committed changes.