Fix process launch from Windows host to Android target.

[chaoren]

Summary

• Denormalized path on Windows host causes bad A packet.
• Executables copied from Windows host doesn't have executable bits.

[chaoren]

Typo was causing SetFilePermissions to fail. (I thought it was an unrelated issue.)

[ovyalov]

Could you verify that remote launch for Linux-Linux and/or OSX<->Linux scenarios works fine with your CL?

[chaoren]

Linux -> Linux verified. OS X -> Linux is going to take a bit of time to set up.

[ovyalov]

lgtm

lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

GDBRemoteCommunicationClient::SendArgumentsPacket (const ProcessLaunchInfo &launch_info)
     // Since we don't get the send argv0 separate from the executable path, we need to
     // make sure to use the actual executable path found in the launch_info...
     std::vector<const char *> argv;
     FileSpec exe_file = launch_info.GetExecutableFile();
     std::string exe_path;
     const char *arg = NULL;
     const Args &launch_args = launch_info.GetArguments();
     if (exe_file)
-        exe_path = exe_file.GetPath();
+        exe_path = exe_file.GetPath(false);
     else
     {
         arg = launch_args.GetArgumentAtIndex(0);
         if (arg)
             exe_path = arg;
     }
     if (!exe_path.empty())
     {
GDBRemoteCommunicationClient::SetFilePermissions (const char *path,
     StringExtractorGDBRemote response;
 
     if (SendPacketAndWaitForResponse(packet, packet_len, response, false) != PacketResult::Success)
         return Error("failed to send '%s' packet", packet);
 
     if (response.GetChar() != 'F')
         return Error("invalid response to '%s' packet", packet);
 
-    return Error(response.GetU32(false, UINT32_MAX), eErrorTypePOSIX);
+    return Error(response.GetU32(UINT32_MAX), eErrorTypePOSIX);
 }
 
 static uint64_t
 ParseHostIOPacketResponse (StringExtractorGDBRemote &response,
                            uint64_t fail_result,
                            Error &error)
 {
     response.SetFilePos(0);

lldb/trunk/source/Target/Target.cpp

if (platform_sp)
                             if (remote_file)
                             {
                                 error = platform_sp->Install(local_file, remote_file);
                                 if (error.Success())
                                 {
                                     module_sp->SetPlatformFileSpec(remote_file);
                                     if (is_main_executable)
                                     {
+                                        platform_sp->SetFilePermissions(remote_file.GetPath(false).c_str(), 0700);
                                         if (launch_info)
                                             launch_info->SetExecutableFile(remote_file, false);
                                     }
                                 }
                                 else
                                     break;
                             }
                         }