[ValueObject::GetPointeeData] Get addr from value for eValueHostAddress values.

[sivachandra]

Summary

After r236447, ValueObject::GetAddressOf returns LLDB_INVALID_ADDRESS
when the value type is eValueHostAddress. For such a case, clients of
GetAddressOf should get the address from the scalar part of the value
instead of using the value returned by GetAddressOf directly.

This change also makes ValueObject::GetAddressOf set the address type to
eAddressTypeHost for values of eValueHostAddress so that clients can
recognize that they need to fetch the address from the scalar part
of the value.

[ovyalov]

lgtm

[clayborg]

Looks good.

source/Core/ValueObject.cpp

else /* (items > 1) */
                 }
                 break;
             case eAddressTypeHost:
                 {
                     const uint64_t max_bytes = GetClangType().GetByteSize(exe_ctx.GetBestExecutionContextScope());
                     if (max_bytes > offset)
                     {
                         size_t bytes_read = std::min<uint64_t>(max_bytes - offset, bytes);
+                        addr = m_value.GetScalar().ULongLong(LLDB_INVALID_ADDRESS);
+                        if (addr == LLDB_INVALID_ADDRESS)
+                            break;
                         heap_buf_ptr->CopyData((uint8_t*)(addr + offset), bytes_read);
                         data.SetData(data_sp);
                         return bytes_read;
                     }
                 }
                 break;
             case eAddressTypeInvalid:
                 break;
ValueObject::GetAddressOf (bool scalar_is_load_address, AddressType *address_type)
     case Value::eValueTypeFileAddress:
         {
             if(address_type)
                 *address_type = m_value.GetValueAddressType ();
             return m_value.GetScalar().ULongLong(LLDB_INVALID_ADDRESS);
         }
         break;
     case Value::eValueTypeHostAddress:
+        {
+            if(address_type)
+                *address_type = m_value.GetValueAddressType ();
+            return LLDB_INVALID_ADDRESS;
+        }
         break;
     }
     if (address_type)
         *address_type = eAddressTypeInvalid;
     return LLDB_INVALID_ADDRESS;
 }
 
 addr_t