[clang] Allow LifetimeExtendedTemporary to have no access specifier

[adamcz]

Summary

The check only runs in debug mode during serialization, but
assert()-fail on:

struct S { const int& x = 7; };

in C++ mode.

[hokein]

thanks.

clang/lib/AST/DeclBase.cpp

986

nit: personally I'd keep the old format style, just appending the new case.

[adamcz]

clang/lib/AST/DeclBase.cpp

986

I like the old formatting a little better too, but this is what clang-format wants to do and I think keeping the code clang-format clean is more valuable in this case. Otherwise everyone submitting here must ignore/silence formatting errors and can no longer auto-format this file.

clang/lib/AST/DeclBase.cpp

#ifndef NDEBUG
   // Suppress this check if any of the following hold:
   // 1. this is the translation unit (and thus has no parent)
   // 2. this is a template parameter (and thus doesn't belong to its context)
   // 3. this is a non-type template parameter
   // 4. the context is not a record
   // 5. it's invalid
   // 6. it's a C++0x static_assert.
   // 7. it's a block literal declaration
-  if (isa<TranslationUnitDecl>(this) ||
-      isa<TemplateTypeParmDecl>(this) ||
-      isa<NonTypeTemplateParmDecl>(this) ||
-      !getDeclContext() ||
-      !isa<CXXRecordDecl>(getDeclContext()) ||
-      isInvalidDecl() ||
-      isa<StaticAssertDecl>(this) ||
-      isa<BlockDecl>(this) ||
+  // 8. it's a temporary with lifetime extended due to being default value.
+  if (isa<TranslationUnitDecl>(this) || isa<TemplateTypeParmDecl>(this) ||
+      isa<NonTypeTemplateParmDecl>(this) || !getDeclContext() ||
+      !isa<CXXRecordDecl>(getDeclContext()) || isInvalidDecl() ||
+      isa<StaticAssertDecl>(this) || isa<BlockDecl>(this) ||
       // FIXME: a ParmVarDecl can have ClassTemplateSpecialization
       // as DeclContext (?).
       isa<ParmVarDecl>(this) ||
       // FIXME: a ClassTemplateSpecialization or CXXRecordDecl can have
       // AS_none as access specifier.
       isa<CXXRecordDecl>(this) ||
-      isa<ClassScopeFunctionSpecializationDecl>(this))
+      isa<ClassScopeFunctionSpecializationDecl>(this) ||
+      isa<LifetimeExtendedTemporaryDecl>(this))
     return true;
 
   assert(Access != AS_none &&
          "Access specifier is AS_none inside a record decl");
 #endif
   return true;
 }
 

clang/test/PCH/cxx-reference.h

 // Header for PCH test cxx-reference.cpp
 
 typedef char (&LR);
 typedef char (&&RR);
 
 char c;
 
 char &lr = c;
 char &&rr = 'c';
 LR &lrlr = c;
 LR &&rrlr = c;
 RR &lrrr = c;
 RR &&rrrr = 'c';
+
+struct S {
+  const int &x = 1; // LifetimeExtendedTemporary inside struct
+};