This is an archive of the discontinued LLVM Phabricator instance.

[MSan] Remove an imposible condition check from CopyOrigin
AbandonedPublic

Authored by stephan.yichao.zhao on Jan 12 2021, 5:35 PM.

Details

Reviewers
eugenis
Summary
  uptr beg = d & ~3UL;
  uptr end = (d + size) & ~3UL;

So end is always >= beg unless overflowed.
But overflow should be checked in a different way.

Diff Detail

Event Timeline

stephan.yichao.zhao requested review of this revision.Jan 12 2021, 5:35 PM
stephan.yichao.zhao created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2021, 5:35 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript