Page MenuHomePhabricator

[Verifier] Extend statepoint verifier to cover more constants
ClosedPublic

Authored by skatkov on Jan 12 2021, 2:46 AM.

Details

Summary

Also old mir tests are updated to meet last changes in STATEPOINT format.

Diff Detail

Event Timeline

skatkov created this revision.Jan 12 2021, 2:46 AM
skatkov requested review of this revision.Jan 12 2021, 2:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2021, 2:46 AM
This revision is now accepted and ready to land.Jan 12 2021, 4:32 AM
dantrushin added inline comments.Jan 12 2021, 4:50 AM
llvm/lib/CodeGen/StackMaps.cpp
95

skipp -> skip

LGTM

Side note: The -1/+1s appearing everywhere confused me until I looked into the getConstMetaVal function. Having the index returned be the second in the tag, value pair seems slightly confusing, but it fits the existing structure.