This addresses Oleksiy's comment in D9307.
Details
Diff Detail
Event Timeline
include/lldb/Host/posix/PipePosix.h | ||
---|---|---|
33 | I'm probably not understanding this correctly. We can't have virtual constructors. I don't think a virtual assignment operator makes much sense either. Do you want a = default move consturctor/assignment operator for PipeBase? (Which does't make sense either, since there's nothing to move in PipeBase.) | |
source/Host/posix/PipePosix.cpp | ||
132–135 | Seems unnecessary. It's neither more concise, nor more efficient. I think I prefer the more straight forward initialization. |
include/lldb/Host/posix/PipePosix.h | ||
---|---|---|
33 | My understanding that moving doesn't work properly for derived classes unless all base types define move constructor and/or assignment operator. |
We may need to extend PipeBase with moving constructor/assignment operator to make moving work for Pipe instances.