This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implemented make_unique_for_overwrite
AbandonedPublic

Authored by ldionne on Dec 19 2020, 10:27 PM.

Details

Reviewers
ahmadbeirkdar
Group Reviewers
Restricted Project
Summary

Implemented std::make_unique_for_overwrite according to the following paper: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1020r1.html
and the rename http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1973r1.pdf

Diff Detail

Event Timeline

ahmadbeirkdar requested review of this revision.Dec 19 2020, 10:27 PM
ahmadbeirkdar created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptDec 19 2020, 10:27 PM

Typo in _LIBCPP_STD_VER check, and an extra semi colon.

There's already an ongoing effort to implement this: D90111.
You might want to sync with the author of the other patch.

There's already an ongoing effort to implement this: D90111.
You might want to sync with the author of the other patch.

Oh thanks, sorry did not know. First time trying to contribute over this platform and to libcxx

ldionne commandeered this revision.Jan 23 2023, 5:31 PM
ldionne added a reviewer: ahmadbeirkdar.
ldionne added a subscriber: ldionne.

Supersedded by D140913, closing.

Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 5:31 PM
ldionne abandoned this revision.Jan 23 2023, 5:31 PM