This is an archive of the discontinued LLVM Phabricator instance.

[mips] [IAS] Add support for expanding LASym with a source register operand.
ClosedPublic

Authored by tomatabacu on Apr 29 2015, 9:53 AM.

Diff Detail

Event Timeline

tomatabacu updated this revision to Diff 25962.May 18 2015, 6:09 AM

Switched over to using createAddu().

dsanders accepted this revision.May 19 2015, 6:33 AM
dsanders edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 19 2015, 6:33 AM
tomatabacu updated this revision to Diff 27513.Jun 11 2015, 8:45 AM
tomatabacu edited edge metadata.

Rebased (for Sean Bruno's convenience).

Toma tells me he's going to untangle this patch from the patches it depends on. The problem is that a couple of those patches have uncovered badly broken MCExpr simplification which is blocking them.

tomatabacu updated this revision to Diff 27572.Jun 12 2015, 5:37 AM

Rebased on top of the new D9523 and made changes accordingly.
Removed unnecessary dependencies on other patches.

This version LGTM with a nit

lib/Target/Mips/AsmParser/MipsAsmParser.cpp
2012–2015

Nit: With this bit added we're not really loading a symbol address anymore, we're adding a symbol address and treating the $0 case as an optimization. I'd suggest hoisting this out into another function (addSymbolAddress()?) or renaming this function.

tomatabacu updated this revision to Diff 27831.Jun 17 2015, 6:08 AM

Addressed LGTM nit.

I decided to rename the function instead of splitting it into two,
as the latter would complicate some upcoming patches.

tomatabacu closed this revision.Jun 17 2015, 7:36 AM