Page MenuHomePhabricator

tomatabacu (Toma Tabacu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2014, 4:31 AM (354 w, 6 d)

Recent Activity

Aug 7 2015

tomatabacu resigned from D11215: Adding altmacro support in integrated assembler. continue of D10591 .
Aug 7 2015, 8:16 AM

Jun 30 2015

tomatabacu committed rL241066: [mips] [IAS] Add support for the .module softfloat/hardfloat directives..
[mips] [IAS] Add support for the .module softfloat/hardfloat directives.
Jun 30 2015, 6:46 AM
tomatabacu closed D9073: [mips] [IAS] Add support for the .module softfloat/hardfloat directives. by committing rL241066: [mips] [IAS] Add support for the .module softfloat/hardfloat directives..
Jun 30 2015, 6:46 AM
tomatabacu committed rL241062: [mips] [IAS] Make .module directives change AssemblerOptions->front()..
[mips] [IAS] Make .module directives change AssemblerOptions->front().
Jun 30 2015, 5:41 AM
tomatabacu closed D10643: [mips] [IAS] Make .module directives change AssemblerOptions->front(). by committing rL241062: [mips] [IAS] Make .module directives change AssemblerOptions->front()..
Jun 30 2015, 5:41 AM
tomatabacu committed rL241052: [mips] [IAS] Add support for the .set oddspreg/nooddspreg directives..
[mips] [IAS] Add support for the .set oddspreg/nooddspreg directives.
Jun 30 2015, 2:37 AM
tomatabacu closed D10657: [mips] [IAS] Add support for the .set oddspreg/nooddspreg directives. by committing rL241052: [mips] [IAS] Add support for the .set oddspreg/nooddspreg directives..
Jun 30 2015, 2:37 AM

Jun 26 2015

tomatabacu committed rL240782: [mips] [IAS] Add partial support for the ULW pseudo-instruction..
[mips] [IAS] Add partial support for the ULW pseudo-instruction.
Jun 26 2015, 6:20 AM
tomatabacu closed D9663: [mips] [IAS] Add partial support for the ULW pseudo-instruction..
Jun 26 2015, 6:20 AM

Jun 25 2015

tomatabacu added inline comments to D9663: [mips] [IAS] Add partial support for the ULW pseudo-instruction..
Jun 25 2015, 8:51 AM
tomatabacu updated the diff for D9663: [mips] [IAS] Add partial support for the ULW pseudo-instruction..

Addressed review comments.
Updated an explanation in a comment.

Jun 25 2015, 8:48 AM
tomatabacu updated the diff for D10657: [mips] [IAS] Add support for the .set oddspreg/nooddspreg directives..

Addressed review comments.

Jun 25 2015, 8:01 AM
tomatabacu abandoned D9346: [mips] [IAS] Fix expansion of LASym with negative offset..

Abandoned because evaluateRelocExpr() needs to be rewritten anyway.

Jun 25 2015, 6:33 AM
tomatabacu abandoned D9344: [mips] [IAS] Fix expansion of LASym with positive offset..

Abandoned due to existing problems with evaluateRelocExpr().

Jun 25 2015, 6:29 AM
tomatabacu committed rL240637: [mips] [IAS] Refactor the emitDirectiveModuleFP() functions. NFC..
[mips] [IAS] Refactor the emitDirectiveModuleFP() functions. NFC.
Jun 25 2015, 5:44 AM
tomatabacu closed D10642: [mips] [IAS] Refactor the emitDirectiveModuleFP() functions. NFC..
Jun 25 2015, 5:44 AM
tomatabacu retitled D10642: [mips] [IAS] Refactor the emitDirectiveModuleFP() functions. NFC. from [mips] [IAS] Refactor the emitDirectiveModuleFP() functions. to [mips] [IAS] Refactor the emitDirectiveModuleFP() functions. NFC..
Jun 25 2015, 4:12 AM
tomatabacu committed rL240630: [mips] [IAS] Refactor the emitDirectiveModuleOddSPReg() functions. NFC..
[mips] [IAS] Refactor the emitDirectiveModuleOddSPReg() functions. NFC.
Jun 25 2015, 3:57 AM
tomatabacu closed D10641: [mips] [IAS] Refactor the emitDirectiveModuleOddSPReg() functions. NFC..
Jun 25 2015, 3:57 AM
tomatabacu committed rL240625: [mips] [IAS] Fix parsing of memory offset expressions with parenthesis depth >1..
[mips] [IAS] Fix parsing of memory offset expressions with parenthesis depth >1.
Jun 25 2015, 2:52 AM
tomatabacu closed D9742: [mips] [IAS] Fix parsing of memory offset expressions with parenthesis depth >1..
Jun 25 2015, 2:52 AM

Jun 24 2015

tomatabacu added a comment to D9742: [mips] [IAS] Fix parsing of memory offset expressions with parenthesis depth >1..

Rafael, are the common-code additions ok with you ?

Jun 24 2015, 5:55 AM

Jun 23 2015

tomatabacu updated the diff for D10643: [mips] [IAS] Make .module directives change AssemblerOptions->front()..

Fixed a dumb bug in my original {set,clear}ModuleFeatureBits():
*The if was preventing the setting of the front options.
Added my proposed test case.
Added dependency on D10657.

Jun 23 2015, 9:57 AM
tomatabacu retitled D10657: [mips] [IAS] Add support for the .set oddspreg/nooddspreg directives. from to [mips] [IAS] Add support for the .set oddspreg/nooddspreg directives..
Jun 23 2015, 9:49 AM
tomatabacu committed rL240410: [mips] [IAS] Add partial support for the ULHU pseudo-instruction..
[mips] [IAS] Add partial support for the ULHU pseudo-instruction.
Jun 23 2015, 7:44 AM
tomatabacu closed D9671: [mips] [IAS] Add partial support for the ULHU pseudo-instruction..
Jun 23 2015, 7:44 AM
tomatabacu committed rL240407: [mips] [IAS] Add support for generating DADDu to createAddu(). NFC..
[mips] [IAS] Add support for generating DADDu to createAddu(). NFC.
Jun 23 2015, 7:05 AM
tomatabacu closed D10568: [mips] [IAS] Add support for generating DADDu to createAddu(). NFC..
Jun 23 2015, 7:05 AM
tomatabacu updated the diff for D9073: [mips] [IAS] Add support for the .module softfloat/hardfloat directives..

Fixed restoration of previous hardfloat settings:

  • The settings aren't actually changed, it's just that when in soft-float they are ignored.
  • emitDirectiveModule{SoftFloat,HardFloat}() doesn't change the MipsABIFlagsSection data anymore, it only prints it.
  • That data is changed by setting/clearing the soft-float bit in STI.FeatureBits and then calling updateABIInfo().
  • updateABIInfo() uses the update mechanism from MipsABIFlagsSection to properly update.

Changed test to use -mips-abi-flags feature of llvm-readobj.
Made the module-hardfloat.s test more thorough.
Rebased on top of D10641, D10642, and D10643, which fix the other .module directives.

Jun 23 2015, 5:56 AM
tomatabacu committed rL240398: [mips] [IAS] Move some function definitions to MipsTargetStreamer.cpp. NFC..
[mips] [IAS] Move some function definitions to MipsTargetStreamer.cpp. NFC.
Jun 23 2015, 5:38 AM
tomatabacu closed D10639: [mips] [IAS] Move some function definitions to MipsTargetStreamer.cpp. NFC..
Jun 23 2015, 5:38 AM
tomatabacu updated D10639: [mips] [IAS] Move some function definitions to MipsTargetStreamer.cpp. NFC..
Jun 23 2015, 5:37 AM
tomatabacu added a comment to D10643: [mips] [IAS] Make .module directives change AssemblerOptions->front()..

I was thinking of the following test:

Jun 23 2015, 3:40 AM
tomatabacu retitled D10643: [mips] [IAS] Make .module directives change AssemblerOptions->front(). from to [mips] [IAS] Make .module directives change AssemblerOptions->front()..
Jun 23 2015, 3:39 AM
tomatabacu added inline comments to D10642: [mips] [IAS] Refactor the emitDirectiveModuleFP() functions. NFC..
Jun 23 2015, 2:45 AM
tomatabacu retitled D10642: [mips] [IAS] Refactor the emitDirectiveModuleFP() functions. NFC. from to [mips] [IAS] Refactor the emitDirectiveModuleFP() functions..
Jun 23 2015, 2:41 AM
tomatabacu retitled D10641: [mips] [IAS] Refactor the emitDirectiveModuleOddSPReg() functions. NFC. from to [mips] [IAS] Refactor the emitDirectiveModuleOddSPReg() functions. NFC..
Jun 23 2015, 2:31 AM
tomatabacu retitled D10639: [mips] [IAS] Move some function definitions to MipsTargetStreamer.cpp. NFC. from to [mips] [IAS] Move some function definitions to MipsTargetStreamer.cpp. NFC..
Jun 23 2015, 2:21 AM

Jun 22 2015

tomatabacu added a comment to D6231: [mips] Expand JAL instructions when PIC is enabled..

That's ok for this patch, but following the principle above I'd suggest asserting that LargeGOT is not in use.

Jun 22 2015, 8:45 AM
tomatabacu updated the diff for D6231: [mips] Expand JAL instructions when PIC is enabled..

Fixed the RuntimeDyld test.
Addressed the other review comments.

Jun 22 2015, 8:41 AM
tomatabacu updated the diff for D10568: [mips] [IAS] Add support for generating DADDu to createAddu(). NFC..

Rebased.

Jun 22 2015, 7:14 AM
tomatabacu committed rL240278: [mips] [IAS] Add support for LAReg with identical source and destination….
[mips] [IAS] Add support for LAReg with identical source and destination…
Jun 22 2015, 6:14 AM
tomatabacu closed D9367: [mips] [IAS] Add support for LAReg with identical source and destination register operands..
Jun 22 2015, 6:14 AM
tomatabacu added a comment to D9524: [mips] [IAS] Add support for the DLA pseudo-instruction and fix problems with DLI.

Right now, there still are some missing pieces:

Jun 22 2015, 6:13 AM
tomatabacu updated the diff for D9524: [mips] [IAS] Add support for the DLA pseudo-instruction and fix problems with DLI.

Addressed review comments.
Changed behaviour to more closely match GAS.
Refactored if-else control flow to early returns.
Added test cases for DLA with $at as an operand.
Added more test cases for unusual behaviours of (D)LA.
Added test cases for mips-expansions-bad.s.
Removed some unnecessary generation checks to fix mips-expansions-bad.s.
Removed unnecessary patch dependecies.
Rebased on top of D10568.

Jun 22 2015, 6:09 AM
tomatabacu committed rL240273: [mips] [IAS] Add support for LASym with identical source and destination….
[mips] [IAS] Add support for LASym with identical source and destination…
Jun 22 2015, 5:13 AM
tomatabacu closed D9366: [mips] [IAS] Add support for LASym with identical source and destination register operands..
Jun 22 2015, 5:12 AM
tomatabacu added inline comments to D9663: [mips] [IAS] Add partial support for the ULW pseudo-instruction..
Jun 22 2015, 2:04 AM
tomatabacu updated the diff for D9663: [mips] [IAS] Add partial support for the ULW pseudo-instruction..

Merged expandUlw() and expandUlhu() together.
Rebased top of the updated D9671.

Jun 22 2015, 2:03 AM

Jun 19 2015

tomatabacu updated the diff for D9671: [mips] [IAS] Add partial support for the ULHU pseudo-instruction..

Addressed review comments (one of them resulted in D10568).
Added a code comment with an example of why we add the SrcReg locally.
Fixed mistake in test/MC/Mips/set-nomacro.s caused by a previous rebase.

Jun 19 2015, 7:45 AM
tomatabacu retitled D10568: [mips] [IAS] Add support for generating DADDu to createAddu(). NFC. from to [mips] [IAS] Add support for generating DADDu to createAddu(). NFC..
Jun 19 2015, 7:27 AM
tomatabacu updated D6267: [mips] Add assembler support for the .cprestore directive..
Jun 19 2015, 4:11 AM
tomatabacu updated the diff for D6267: [mips] Add assembler support for the .cprestore directive..

Outlined the (inPicMode() && !(isABI_N32() || isABI_N64())) condition into a separate function.
Switched to using !isInt<16>() in createCpRestoreMemOp() if condition.
Moved forbidModuleDirective() calls to the MipsTargetStreamer base class.
Removed redundant addition to the .set reorder NOP-creation condition.
Improved code comments to better explain why we need a NOP after the JALR in .set noreorder.

Jun 19 2015, 4:10 AM

Jun 18 2015

tomatabacu added a comment to D6231: [mips] Expand JAL instructions when PIC is enabled..

Looking back through the comments, I believe the remaining issues are:

  • Duplicated nops
Jun 18 2015, 9:58 AM
tomatabacu updated the diff for D6231: [mips] Expand JAL instructions when PIC is enabled..

Improved the code which gets the JalSym from the original JalExpr.
Moved relocation creation before MCInst creation in order to improve readability. (NFC)
Added FIXME comments for the remaining problems.

Jun 18 2015, 9:45 AM
tomatabacu updated the diff for D9367: [mips] [IAS] Add support for LAReg with identical source and destination register operands..

Daniel, is shortening IntermediateDstReg to TmpReg OK with you ?
You pointed that out in private, but since I ended up making the change, your position should be included in the public review.

Jun 18 2015, 3:51 AM
tomatabacu updated the diff for D9366: [mips] [IAS] Add support for LASym with identical source and destination register operands..

I think this is the final version of this patch, as all of its dependencies have been committed.
Daniel, could take another look at this please ?

Jun 18 2015, 3:29 AM

Jun 17 2015

tomatabacu committed rL239910: [mips] [IAS] Add support for expanding LASym with a source register operand..
[mips] [IAS] Add support for expanding LASym with a source register operand.
Jun 17 2015, 7:36 AM
tomatabacu closed D9348: [mips] [IAS] Add support for expanding LASym with a source register operand..
Jun 17 2015, 7:36 AM
tomatabacu committed rL239905: [mips] [IAS] Add support for the B{L,G}{T,E}(U) branch pseudo-instructions..
[mips] [IAS] Add support for the B{L,G}{T,E}(U) branch pseudo-instructions.
Jun 17 2015, 6:24 AM
tomatabacu closed D8537: [mips] [IAS] Add support for the B{L,G}{T,E}(U) branch pseudo-instructions..
Jun 17 2015, 6:24 AM
tomatabacu updated the diff for D9348: [mips] [IAS] Add support for expanding LASym with a source register operand..

Addressed LGTM nit.

Jun 17 2015, 6:08 AM
tomatabacu committed rL239901: [mips] [IAS] Fix LA with relative label operands..
[mips] [IAS] Fix LA with relative label operands.
Jun 17 2015, 5:34 AM
tomatabacu closed D10498: [mips] [IAS] Fix LA with relative label operands..
Jun 17 2015, 5:34 AM
tomatabacu updated the diff for D8537: [mips] [IAS] Add support for the B{L,G}{T,E}(U) branch pseudo-instructions..

Addressed LGTM style nit.
Updated the ATReg-related code comment, as a result of this refactoring.

Jun 17 2015, 5:13 AM
tomatabacu committed rL239899: [mips] [IAS] Add test for SW with relative label operands. NFC..
[mips] [IAS] Add test for SW with relative label operands. NFC.
Jun 17 2015, 4:50 AM
tomatabacu closed D10497: [mips] [IAS] Add test for SW with relative label operands. NFC..
Jun 17 2015, 4:50 AM
tomatabacu updated the diff for D10498: [mips] [IAS] Fix LA with relative label operands..

Ran clang-format on changes.

Jun 17 2015, 3:59 AM
tomatabacu retitled D10498: [mips] [IAS] Fix LA with relative label operands. from [mips] [IAS] Fix LA with $tmp symbol operands. to [mips] [IAS] Fix LA with relative label operands..
Jun 17 2015, 3:51 AM
tomatabacu committed rL239897: [mips] [IAS] Fix LW with relative label operands..
[mips] [IAS] Fix LW with relative label operands.
Jun 17 2015, 3:48 AM
tomatabacu closed D9938: [mips] [IAS] Fix LW with relative label operands..
Jun 17 2015, 3:47 AM
tomatabacu retitled D10497: [mips] [IAS] Add test for SW with relative label operands. NFC. from [mips] [IAS] Add test for SW with $tmp symbol operands. NFC. to [mips] [IAS] Add test for SW with relative label operands. NFC..
Jun 17 2015, 3:46 AM
tomatabacu retitled D9938: [mips] [IAS] Fix LW with relative label operands. from [mips] [IAS] Fix LW with $tmp symbol operands. to [mips] [IAS] Fix LW with relative label operands..
Jun 17 2015, 3:45 AM
tomatabacu retitled D10498: [mips] [IAS] Fix LA with relative label operands. from to [mips] [IAS] Fix LA with $tmp symbol operands..
Jun 17 2015, 3:10 AM
tomatabacu retitled D10497: [mips] [IAS] Add test for SW with relative label operands. NFC. from to [mips] [IAS] Add test for SW with $tmp symbol operands. NFC..
Jun 17 2015, 3:06 AM
tomatabacu updated the diff for D9742: [mips] [IAS] Fix parsing of memory offset expressions with parenthesis depth >1..

Added test case with MIPS-specific expression.

Jun 17 2015, 2:51 AM

Jun 16 2015

tomatabacu updated D9938: [mips] [IAS] Fix LW with relative label operands..
Jun 16 2015, 8:04 AM
tomatabacu retitled D9938: [mips] [IAS] Fix LW with relative label operands. from [mips] [IAS] Fix creation of MCSymbolRefExpr's of $tmp symbols in evaluateRelocExpr(). to [mips] [IAS] Fix LW with $tmp symbol operands..
Jun 16 2015, 8:02 AM
tomatabacu updated D9938: [mips] [IAS] Fix LW with relative label operands..
Jun 16 2015, 7:58 AM
tomatabacu committed rL239818: [mips] Don't propagate -mfpxx by default if soft/single float were also set..
[mips] Don't propagate -mfpxx by default if soft/single float were also set.
Jun 16 2015, 6:58 AM
tomatabacu closed D10387: [mips] Don't propagate -mfpxx by default if soft/single float were also set..
Jun 16 2015, 6:58 AM
tomatabacu updated the diff for D10387: [mips] Don't propagate -mfpxx by default if soft/single float were also set..

Addressed LGTM comment.

Jun 16 2015, 5:56 AM
tomatabacu committed rL239811: [mips] [IAS] Refactor symbol-address loading code into a helper function. NFC..
[mips] [IAS] Refactor symbol-address loading code into a helper function. NFC.
Jun 16 2015, 5:20 AM
tomatabacu closed D9523: [mips] [IAS] Refactor symbol-address loading code into a helper function. NFC..
Jun 16 2015, 5:20 AM

Jun 12 2015

tomatabacu updated the diff for D9367: [mips] [IAS] Add support for LAReg with identical source and destination register operands..

Moved ATReg inside the if block, as it is not used again after that.
Shortened the name of IntermediateDstReg to TmpReg.
Rebased on top of the new D9523, D9348 and D9366.
Removed unnecessary dependencies on other patches.

Jun 12 2015, 6:25 AM
tomatabacu updated the diff for D9366: [mips] [IAS] Add support for LASym with identical source and destination register operands..

Moved ATReg inside the if block, as it is not used again after that.

Jun 12 2015, 6:14 AM
tomatabacu updated the diff for D9366: [mips] [IAS] Add support for LASym with identical source and destination register operands..

Replaced the UseAT variable with its corresponding condition, as it was being used only once.
Put the "SrcReg != Mips::NoRegister" condition in a variable, as it is now used twice.
Shortened the name of IntermediateDstReg to TmpReg.
Rebased on top of the new D9523 and D9348.
Removed unnecessary dependencies on other patches.

Jun 12 2015, 6:02 AM
tomatabacu updated the diff for D9348: [mips] [IAS] Add support for expanding LASym with a source register operand..

Rebased on top of the new D9523 and made changes accordingly.
Removed unnecessary dependencies on other patches.

Jun 12 2015, 5:37 AM
tomatabacu updated the diff for D9523: [mips] [IAS] Refactor symbol-address loading code into a helper function. NFC..

Removed all dependencies on other patches, as they were unnecessary.

Jun 12 2015, 5:23 AM

Jun 11 2015

tomatabacu updated the diff for D9663: [mips] [IAS] Add partial support for the ULW pseudo-instruction..

Rebased.

Jun 11 2015, 11:30 AM
tomatabacu updated the diff for D9671: [mips] [IAS] Add partial support for the ULHU pseudo-instruction..

Rebased.

Jun 11 2015, 11:24 AM
tomatabacu planned changes to D6267: [mips] Add assembler support for the .cprestore directive..
Jun 11 2015, 11:11 AM
tomatabacu updated the diff for D6267: [mips] Add assembler support for the .cprestore directive..

Rebased (for Sean Bruno's convenience).

Jun 11 2015, 11:11 AM
tomatabacu planned changes to D6231: [mips] Expand JAL instructions when PIC is enabled..
Jun 11 2015, 10:59 AM
tomatabacu updated the diff for D6231: [mips] Expand JAL instructions when PIC is enabled..

Rebased (for Sean Bruno's convenience).

Jun 11 2015, 10:56 AM
tomatabacu updated the diff for D9938: [mips] [IAS] Fix LW with relative label operands..

Rebased (for Sean Bruno's convenience).

Jun 11 2015, 10:45 AM
tomatabacu planned changes to D9524: [mips] [IAS] Add support for the DLA pseudo-instruction and fix problems with DLI.

Will address review comments and other issues soon.

Jun 11 2015, 10:35 AM
tomatabacu updated the diff for D9524: [mips] [IAS] Add support for the DLA pseudo-instruction and fix problems with DLI.

Rebased (for Sean Bruno's convenience).

Jun 11 2015, 10:33 AM
tomatabacu added inline comments to D9367: [mips] [IAS] Add support for LAReg with identical source and destination register operands..
Jun 11 2015, 9:37 AM
tomatabacu updated the diff for D9367: [mips] [IAS] Add support for LAReg with identical source and destination register operands..

Addressed review comments.
Rebased (for Sean Bruno's convenience).

Jun 11 2015, 9:31 AM