This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Use regex for code object version in hip tests
ClosedPublic

Authored by JonChesterfield on Dec 16 2020, 7:47 AM.

Details

Summary

[NFC] Use regex for code object version in hip tests

Extracted from D93258. Makes tests robust to changes in default
code object version.

Diff Detail

Event Timeline

JonChesterfield requested review of this revision.Dec 16 2020, 7:47 AM
JonChesterfield created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2020, 7:47 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
t-tye added a subscriber: t-tye.Dec 16 2020, 7:57 AM
t-tye added inline comments.
clang/test/Driver/hip-code-object-version.hip
56–57

If the upstream default is being changed to 3 does this need to also be 3?

t-tye added a reviewer: t-tye.Dec 16 2020, 7:57 AM
t-tye added inline comments.
clang/test/Driver/hip-code-object-version.hip
56–57

I can also help getting this landed in to internal branches.

clang/test/Driver/hip-code-object-version.hip
56–57

Thanks. And yeah, it'll be changed to =3 as part of D93258. Until then, test needs to match the clang front end.

t-tye accepted this revision.Dec 16 2020, 8:58 AM

LGTM

This revision is now accepted and ready to land.Dec 16 2020, 8:58 AM
This revision was landed with ongoing or failed builds.Dec 16 2020, 9:00 AM
This revision was automatically updated to reflect the committed changes.