This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [Process/FreeBSDRemote] Replace GetRegisterSetCount()
ClosedPublic

Authored by mgorny on Dec 16 2020, 6:54 AM.

Details

Summary

Replace the wrong code in GetRegisterSetCount() with a constant return.
The original code passed register index in place of register set index,
effectively getting always true. Correcting the code to check for
register set existence is not possible as LLDB supports only eliminating
last register sets. Just return the full number for now which should
be NFC.

Diff Detail

Event Timeline

mgorny requested review of this revision.Dec 16 2020, 6:54 AM
mgorny created this revision.
labath accepted this revision.Dec 17 2020, 8:55 AM
This revision is now accepted and ready to land.Dec 17 2020, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2020, 9:02 AM