This is an archive of the discontinued LLVM Phabricator instance.

Differential D93116

LNT: Use relative URLs for Javascript-based URLs.
ClosedPublic

Authored by tnfchris on Dec 11 2020, 6:00 AM.

Details

Reviewers
thopre
Summary

Having _external=True seems to break links when LNT is hosted behind a
reverse-proxy. This has been observed previously as
https://reviews.llvm.org/D85425 for example.

Diff Detail

Event Timeline

tnfchris requested review of this revision.Dec 11 2020, 6:00 AM
tnfchris created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2020, 6:00 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B82032: Diff 311205.Dec 11 2020, 6:05 AM
thopre accepted this revision.Dec 11 2020, 6:42 AM

LGTM

This revision is now accepted and ready to land.Dec 11 2020, 6:42 AM
tnfchris closed this revision.Dec 13 2020, 6:18 AM

Revision Contents

PathSize
lnt/
server/
ui/
templates/
2 lines

Diff 311205

lnt/server/ui/templates/layout.html

Context not available.
<head> <head>
<meta charset="UTF-8"/> <meta charset="UTF-8"/>
<script>var lnt_url_base="{{ url_for('.index', _external=True) }}".replace(/\/$/, "");</script> <script>var lnt_url_base="{{ url_for('.index', _external=False) }}".replace(/\/$/, "");</script>
<link href="{{ url_for('.static', filename='bootstrap/css/bootstrap.min.css') <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap.min.css')
}}" rel="stylesheet" media="screen"/> }}" rel="stylesheet" media="screen"/>
<link href="{{ url_for('.static', filename='bootstrap/css/bootstrap-responsive.min.css') <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap-responsive.min.css')
Context not available.