This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: Default overflow operations to expand so we don't have to assume targets are lying
ClosedPublic

Authored by jvesely on Apr 24 2015, 2:15 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jvesely updated this revision to Diff 24411.Apr 24 2015, 2:15 PM
jvesely retitled this revision from to CodeGen: Default overflow operations to expand so we don't have to assume targets are lying.
jvesely updated this object.
jvesely edited the test plan for this revision. (Show Details)
jvesely added a reviewer: resistor.
jvesely set the repository for this revision to rL LLVM.
jvesely added a subscriber: Unknown Object (MLST).
ab accepted this revision.Apr 28 2015, 11:56 AM
ab added a reviewer: ab.
ab added a subscriber: ab.

This makes sense; I did some archeology and didn't find any good reason either. I assume no target actually marked this as Legal?

This revision is now accepted and ready to land.Apr 28 2015, 11:56 AM

Couple of targets (aarch64, arm x86, sparc) mark those as custom. I didn't find any that would set it to legal. I also grepped for patterns/instructions in .td and did not find any.

This revision was automatically updated to reflect the committed changes.