This is an archive of the discontinued LLVM Phabricator instance.

[libc++] [LWG3374] Mark `to_address(const Ptr& p)` overload `constexpr`.
ClosedPublic

Authored by curdeius on Dec 4 2020, 8:23 AM.

Diff Detail

Event Timeline

curdeius requested review of this revision.Dec 4 2020, 8:23 AM
curdeius created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 4 2020, 8:23 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Dec 4 2020, 8:33 AM
ldionne added inline comments.
libcxx/docs/Cxx2aStatusIssuesStatus.csv
281

Is there a reason why we don't have a version of completion for LWG issues? It would be nice if we could say Complete|12.0 like we do for papers. WDYT?

This revision is now accepted and ready to land.Dec 4 2020, 8:33 AM
curdeius added inline comments.Dec 4 2020, 9:38 AM
libcxx/docs/Cxx2aStatusIssuesStatus.csv
281

I was thinking about just when modifying this line... I'll add this new column before landing this patch.

curdeius updated this revision to Diff 309558.Dec 4 2020, 9:48 AM
  • Rebase with added version
ldionne accepted this revision.Dec 4 2020, 12:54 PM

LGTM once CI passes. I think you fixed those issues already, right? If so, don't bother rebasing just to trigger CI, and just commit this. Thanks!

This revision was landed with ongoing or failed builds.Dec 6 2020, 6:26 AM
This revision was automatically updated to reflect the committed changes.