This is an archive of the discontinued LLVM Phabricator instance.

Differential D92632

[dfsan] Add a test case of storing zero
ClosedPublic

Authored by stephan.yichao.zhao on Dec 3 2020, 9:41 PM.

Download Raw Diff

Details

Reviewers

Commits

rGfa4c3f70ff07: [dfsan] Add a test case of storing zero

Summary

This covers a branch in storeShadow.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

stephan.yichao.zhao requested review of this revision.Dec 3 2020, 9:41 PM

stephan.yichao.zhao created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 9:41 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B81065: Diff 309455.Dec 3 2020, 10:22 PM

morehouse added inline comments.Dec 4 2020, 6:18 AM

llvm/test/Instrumentation/DataFlowSanitizer/store.ll
163	Why is it storing i64 shadow?

stephan.yichao.zhao marked an inline comment as done.Dec 4 2020, 8:36 AM

stephan.yichao.zhao added inline comments.

llvm/test/Instrumentation/DataFlowSanitizer/store.ll
163	It is testing this branch: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp#L1465 The shadow of (i32 0) is (i64 0).

morehouse accepted this revision.Dec 4 2020, 9:39 AM

morehouse added inline comments.

llvm/test/Instrumentation/DataFlowSanitizer/store.ll
163	Right, of course. I was thinking of TLS, where the shadow would be i16.

This revision is now accepted and ready to land.Dec 4 2020, 9:39 AM

Closed by commit rGfa4c3f70ff07: [dfsan] Add a test case of storing zero (authored by Jianzhou Zhao <jianzhouzh@google.com>). · Explain WhyDec 4 2020, 12:29 PM

This revision was automatically updated to reflect the committed changes.

Jianzhou Zhao <jianzhouzh@google.com> added a commit: rGfa4c3f70ff07: [dfsan] Add a test case of storing zero.

Revision Contents

Path

Size

llvm/

test/

Instrumentation/

DataFlowSanitizer/

6 lines

Diff 309613

llvm/test/Instrumentation/DataFlowSanitizer/store.ll

	Show First 20 Lines • Show All 152 Lines • ▼ Show 20 Lines		define void @store64(i64 %v, i64* %p) {
	; COMBINE_PTR_LABEL: insertelement {{.*}} i16			; COMBINE_PTR_LABEL: insertelement {{.*}} i16
	; COMBINE_PTR_LABEL: bitcast i16* {{.}} <8 x i16>			; COMBINE_PTR_LABEL: bitcast i16* {{.}} <8 x i16>
	; COMBINE_PTR_LABEL: store <8 x i16>			; COMBINE_PTR_LABEL: store <8 x i16>
	; COMBINE_PTR_LABEL: store i64			; COMBINE_PTR_LABEL: store i64

	store i64 %v, i64* %p			store i64 %v, i64* %p
	ret void			ret void
	}			}

				define void @store_zero(i32* %p) {
				; NO_COMBINE_PTR_LABEL: store i64 0, i64* {{.*}}, align 2
				morehouseUnsubmitted Not Done Reply Inline Actions Why is it storing i64 shadow? morehouse: Why is it storing i64 shadow?
				stephan.yichao.zhaoAuthorUnsubmitted Done Reply Inline Actions It is testing this branch: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp#L1465 The shadow of (i32 0) is (i64 0). stephan.yichao.zhao: It is testing this branch: https://github.com/llvm/llvm…
				morehouseUnsubmitted Not Done Reply Inline Actions Right, of course. I was thinking of TLS, where the shadow would be i16. morehouse: Right, of course. I was thinking of TLS, where the shadow would be i16.
				store i32 0, i32* %p
				ret void
				}